Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Unified Diff: chrome/browser/download/notification/download_notification_browsertest.cc

Issue 1145953002: [Download Notification] change notification type from SIMPLE to BASE_FORMAT (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/download/notification/download_notification_item.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/notification/download_notification_browsertest.cc
diff --git a/chrome/browser/download/notification/download_notification_browsertest.cc b/chrome/browser/download/notification/download_notification_browsertest.cc
index 22d90833657282640f57418da86930bef005fd3e..369fccd8b603f30ccaf0196b13e53d690d963eee 100644
--- a/chrome/browser/download/notification/download_notification_browsertest.cc
+++ b/chrome/browser/download/notification/download_notification_browsertest.cc
@@ -384,7 +384,7 @@ IN_PROC_BROWSER_TEST_F(DownloadNotificationTest, DownloadFile) {
IDS_DOWNLOAD_STATUS_DOWNLOADED_TITLE,
download_item()->GetFileNameToReportUser().LossyDisplayName()),
GetNotification(notification_id())->title());
- EXPECT_EQ(message_center::NOTIFICATION_TYPE_SIMPLE,
+ EXPECT_EQ(message_center::NOTIFICATION_TYPE_BASE_FORMAT,
GetNotification(notification_id())->type());
// Confirms that there is only one notification.
@@ -608,7 +608,7 @@ IN_PROC_BROWSER_TEST_F(DownloadNotificationTest, InterruptDownload) {
l10n_util::GetStringUTF16(
IDS_DOWNLOAD_INTERRUPTED_STATUS_NETWORK_ERROR)),
GetNotification(notification_id())->message());
- EXPECT_EQ(message_center::NOTIFICATION_TYPE_SIMPLE,
+ EXPECT_EQ(message_center::NOTIFICATION_TYPE_BASE_FORMAT,
GetNotification(notification_id())->type());
}
@@ -721,9 +721,9 @@ IN_PROC_BROWSER_TEST_F(DownloadNotificationTest, DownloadMultipleFiles) {
}
// Confirms the types of download notifications are correct.
- EXPECT_EQ(message_center::NOTIFICATION_TYPE_SIMPLE,
+ EXPECT_EQ(message_center::NOTIFICATION_TYPE_BASE_FORMAT,
GetNotification(notification_id1)->type());
- EXPECT_EQ(message_center::NOTIFICATION_TYPE_SIMPLE,
+ EXPECT_EQ(message_center::NOTIFICATION_TYPE_BASE_FORMAT,
GetNotification(notification_id2)->type());
}
@@ -811,7 +811,7 @@ IN_PROC_BROWSER_TEST_F(DownloadNotificationTest, IncognitoDownloadFile) {
IDS_DOWNLOAD_STATUS_DOWNLOADED_TITLE,
download_item()->GetFileNameToReportUser().LossyDisplayName()),
GetNotification(notification_id())->title());
- EXPECT_EQ(message_center::NOTIFICATION_TYPE_SIMPLE,
+ EXPECT_EQ(message_center::NOTIFICATION_TYPE_BASE_FORMAT,
GetNotification(notification_id())->type());
// Opens the message center.
@@ -891,9 +891,9 @@ IN_PROC_BROWSER_TEST_F(DownloadNotificationTest,
}
// Confirms the types of download notifications are correct.
- EXPECT_EQ(message_center::NOTIFICATION_TYPE_SIMPLE,
+ EXPECT_EQ(message_center::NOTIFICATION_TYPE_BASE_FORMAT,
GetNotification(notification_id1)->type());
- EXPECT_EQ(message_center::NOTIFICATION_TYPE_SIMPLE,
+ EXPECT_EQ(message_center::NOTIFICATION_TYPE_BASE_FORMAT,
GetNotification(notification_id2)->type());
chrome::CloseWindow(incognito_browser());
@@ -1044,10 +1044,10 @@ IN_PROC_BROWSER_TEST_F(MultiProfileDownloadNotificationTest,
}
// Confirms the types of download notifications are correct.
- EXPECT_EQ(message_center::NOTIFICATION_TYPE_SIMPLE,
+ EXPECT_EQ(message_center::NOTIFICATION_TYPE_BASE_FORMAT,
GetNotification(notification_id1)->type());
- EXPECT_EQ(message_center::NOTIFICATION_TYPE_SIMPLE,
+ EXPECT_EQ(message_center::NOTIFICATION_TYPE_BASE_FORMAT,
GetNotification(notification_id2)->type());
- EXPECT_EQ(message_center::NOTIFICATION_TYPE_SIMPLE,
+ EXPECT_EQ(message_center::NOTIFICATION_TYPE_BASE_FORMAT,
GetNotification(notification_id3)->type());
}
« no previous file with comments | « no previous file | chrome/browser/download/notification/download_notification_item.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698