Issue 1145953002: [Download Notification] change notification type from SIMPLE to BASE_FORMAT

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1145953002: [Download Notification] change notification type from SIMPLE to BASE_FORMAT (Closed)

Created:
5 years, 7 months ago by yoshiki

Modified:
5 years, 7 months ago

Reviewers:
asanka

CC:
asanka, benjhayden+dwatch_chromium.org, chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Download Notification] change notification type from SIMPLE to BASE_FORMAT The type SIMPLE is for web notification and we should use the type BASE_FORMAT for normal type notifications. BUG=489975 TEST=manually Committed: https://crrev.com/c1a1691c5f2547655bb527f18df64e86615f509f Cr-Commit-Position: refs/heads/master@{#330765}

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -13 lines)			Patch
	M	chrome/browser/download/notification/download_notification_browsertest.cc	View		6 chunks	+10 lines, -10 lines	0 comments	Download
	M	chrome/browser/download/notification/download_notification_item.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145953002/1

5 years, 7 months ago (2015-05-20 17:04:44 UTC) #5

commit-bot: I haz the power

5 years, 7 months ago (2015-05-20 17:50:17 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/c1a1691c5f2547655bb527f18df64e86615f509f
Cr-Commit-Position: refs/heads/master@{#330765}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages