Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1145863002: Disable stuck key detection on ChromeOS. (Closed)

Created:
5 years, 7 months ago by Jamie
Modified:
5 years, 7 months ago
Reviewers:
Wez
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable stuck key detection on ChromeOS. Since we can't rely on the modifier flags on ChromeOS, we can't use them as a way to detect stuck modifier keys. This means that some actions (including locking the screen) will result in Ctrl and Shift being stuck, effectively regressing crbug.com/464534. BUG=337509, 484329 Committed: https://crrev.com/feebce3f1423aa54b5fd4255ef6f747fbee58fa7 Cr-Commit-Position: refs/heads/master@{#330899}

Patch Set 1 #

Patch Set 2 : Rebase & fix compilation errors. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -3 lines) Patch
M remoting/client/plugin/chromoting_instance.cc View 1 2 chunks +8 lines, -1 line 0 comments Download
M remoting/client/plugin/pepper_input_handler.h View 2 chunks +8 lines, -0 lines 0 comments Download
M remoting/client/plugin/pepper_input_handler.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Jamie
ptal
5 years, 7 months ago (2015-05-20 00:09:22 UTC) #2
Wez
LGTM What evidence do we have that the stuck modifier hack doesn't also break things ...
5 years, 7 months ago (2015-05-20 18:48:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145863002/1
5 years, 7 months ago (2015-05-20 19:37:42 UTC) #5
Jamie
On 2015/05/20 18:48:45, Wez wrote: > LGTM > > What evidence do we have that ...
5 years, 7 months ago (2015-05-20 19:42:37 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/39596)
5 years, 7 months ago (2015-05-20 19:52:18 UTC) #8
Jamie
Rebase & fix compilation errors.
5 years, 7 months ago (2015-05-21 01:12:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145863002/20001
5 years, 7 months ago (2015-05-21 01:13:38 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-21 04:46:21 UTC) #13
commit-bot: I haz the power
5 years, 7 months ago (2015-05-21 04:47:17 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/feebce3f1423aa54b5fd4255ef6f747fbee58fa7
Cr-Commit-Position: refs/heads/master@{#330899}

Powered by Google App Engine
This is Rietveld 408576698