Disable stuck key detection on ChromeOS.

remoting/client/plugin/chromoting_instance.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/client/plugin/chromoting_instance.h"
 
 #include <string>
 #include <vector>
 
 #if defined(OS_NACL)
@@ skipping 625 matching lines @@
   if (data.HasKey("capabilities")) {
     if (!data.GetString("capabilities", &capabilities)) {
       LOG(ERROR) << "Invalid connect() data.";
       return;
     }
   }
 
   VLOG(0) << "Connecting to " << host_jid
           << ". Local jid: " << local_jid << ".";
 
+  std::string key_filter;
 #if defined(OS_NACL)
-  std::string key_filter;
   if (!data.GetString("keyFilter", &key_filter)) {
     NOTREACHED();
     normalizing_input_filter_.reset(new protocol::InputFilter(&key_mapper_));
   } else if (key_filter == "mac") {
     normalizing_input_filter_.reset(
         new NormalizingInputFilterMac(&key_mapper_));
   } else if (key_filter == "cros") {
     normalizing_input_filter_.reset(
         new NormalizingInputFilterCros(&key_mapper_));
   } else {
     DCHECK(key_filter.empty());
     normalizing_input_filter_.reset(new protocol::InputFilter(&key_mapper_));
   }
 #elif defined(OS_MACOSX)
   normalizing_input_filter_.reset(new NormalizingInputFilterMac(&key_mapper_));
 #elif defined(OS_CHROMEOS)
+  key_filter = "cros";
   normalizing_input_filter_.reset(new NormalizingInputFilterCros(&key_mapper_));
 #else
   normalizing_input_filter_.reset(new protocol::InputFilter(&key_mapper_));
 #endif
   input_handler_.set_input_stub(normalizing_input_filter_.get());
 
+  // Enable stuck modifier key detection on platforms other than ChromeOS.
+  // ChromeOS doesn't set modifier flags for "rewritten" keyboard events
+  // such as Alt+Backspace, which causes ReleaseAllIfModifiersStuck to
+  // incorrectly release all keys, so don't enable it on that platform.
+  input_handler_.set_detect_stuck_modifiers(key_filter != "cros");
+
   // PPB_VideoDecoder is not always enabled because it's broken in some versions
   // of Chrome. See crbug.com/447403 .
   bool enable_video_decode_renderer = false;
   if (data.GetBoolean("enableVideoDecodeRenderer",
                       &enable_video_decode_renderer) &&
       enable_video_decode_renderer) {
     LogToWebapp("Initializing 3D renderer.");
     video_renderer_.reset(new PepperVideoRenderer3D());
     if (!video_renderer_->Initialize(this, context_, this))
       video_renderer_.reset();
@@ skipping 510 matching lines @@
 
 #if !defined(OS_NACL)
   // Log messages are forwarded to the webapp only in PNaCl version of the
   // plugin, so ProcessLogToUI() needs to be called explicitly in the non-PNaCl
   // version.
   ProcessLogToUI(message);
 #endif  // !defined(OS_NACL)
 }
 
 }  // namespace remoting