content/public/test/test_file_error_injector.cc - Issue 11458003: Remove scoped_refptr::release which is confusing and causes leaks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/test/test_file_error_injector.cc

Issue 11458003: Remove scoped_refptr::release which is confusing and causes leaks. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix mac Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/public/test/test_file_error_injector.cc

diff --git a/content/public/test/test_file_error_injector.cc b/content/public/test/test_file_error_injector.cc

index 0414eeb25ee7148c297bee185c99ab06c7472854..71e6a764226f6abf3ffc796862018214b83a6808 100644

--- a/content/public/test/test_file_error_injector.cc

+++ b/content/public/test/test_file_error_injector.cc

@@ -313,7 +313,7 @@ TestFileErrorInjector::TestFileErrorInjector(

// This code is only used for browser_tests, so a

// DownloadManager is always a DownloadManagerImpl.

download_manager_(

- static_cast<DownloadManagerImpl*>(download_manager.release())) {

+ static_cast<DownloadManagerImpl*>(download_manager.get())) {

// Record the value of the pointer, for later validation.

created_factory_ =

new DownloadFileWithErrorsFactory(