content/browser/device_orientation/accelerometer_mac.cc - Issue 11458003: Remove scoped_refptr::release which is confusing and causes leaks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/device_orientation/accelerometer_mac.cc

Issue 11458003: Remove scoped_refptr::release which is confusing and causes leaks. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix mac Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/device_orientation/accelerometer_mac.cc

diff --git a/content/browser/device_orientation/accelerometer_mac.cc b/content/browser/device_orientation/accelerometer_mac.cc

index 6ebe7e3de544c33f380b707168bd85c1be596497..04c5d71b65c213c01b5400122be7bc8dd921e17d 100644

--- a/content/browser/device_orientation/accelerometer_mac.cc

+++ b/content/browser/device_orientation/accelerometer_mac.cc

@@ -93,7 +93,8 @@ const Orientation* AccelerometerMac::GetOrientation() {

DCHECK_GE(orientation->gamma(), -90.0);

DCHECK_LT(orientation->gamma(), 90.0);

- return orientation.release();

+ orientation->AddRef();

+ return orientation.get();

}

bool AccelerometerMac::Init() {