Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1288)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1145773003: Remove the Document.charset setter (making it readonly) (Closed)

Created:
5 years, 7 months ago by philipj_slow
Modified:
5 years, 7 months ago
Reviewers:
davve
CC:
blink-reviews, tyoshino+watch_chromium.org, blink-reviews-html_chromium.org, arv+blink, vivekg, gavinp+loader_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, vivekg_samsung, Inactive, Nate Chapin, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove the Document.charset setter (making it readonly) Intent to Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/vr1RANmrniU/oWAoayNP74QJ HTMLFormControlElementTest and HTMLSelectElementTest don't actually need to call Document::setCharset(), as they use APIs where the text has already been decoded from UTF-8. BUG=438392 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195617

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : split out fast/encoding/external-script-charset.xhtml #

Patch Set 4 : fix webexposed tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -93 lines) Patch
M LayoutTests/fast/dom/Document/document-charset.html View 1 2 1 chunk +6 lines, -22 lines 0 comments Download
M LayoutTests/fast/dom/Document/document-charset-expected.txt View 1 2 2 chunks +4 lines, -15 lines 0 comments Download
M LayoutTests/fast/dom/frame-loading-via-document-write.html View 3 chunks +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/dom/frame-loading-via-document-write-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/encoding/css-charset-default.xhtml View 3 chunks +0 lines, -5 lines 0 comments Download
M LayoutTests/fast/encoding/css-charset-default-expected.txt View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
M LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/Document.h View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 2 3 1 chunk +0 lines, -14 lines 0 comments Download
M Source/core/dom/Document.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/UseCounter.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/html/HTMLFormControlElementTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLSelectElementTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/parser/TextResourceDecoder.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/parser/TextResourceDecoder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/DocumentLoader.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/loader/DocumentLoader.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/loader/DocumentWriter.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/loader/DocumentWriter.cpp View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
philipj_slow
rebase
5 years, 7 months ago (2015-05-19 13:06:05 UTC) #1
philipj_slow
split out fast/encoding/external-script-charset.xhtml
5 years, 7 months ago (2015-05-19 22:56:17 UTC) #2
davve
lgtm
5 years, 7 months ago (2015-05-20 08:15:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145773003/40001
5 years, 7 months ago (2015-05-20 08:57:26 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/55795)
5 years, 7 months ago (2015-05-20 12:14:06 UTC) #8
philipj_slow
fix webexposed tests
5 years, 7 months ago (2015-05-20 12:55:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145773003/60001
5 years, 7 months ago (2015-05-20 12:55:58 UTC) #12
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 14:10:25 UTC) #13
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195617

Powered by Google App Engine
This is Rietveld 408576698