Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: LayoutTests/fast/dom/Document/document-charset.html

Issue 1145773003: Remove the Document.charset setter (making it readonly) (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: fix webexposed tests Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | LayoutTests/fast/dom/Document/document-charset-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/fast/dom/Document/document-charset.html
diff --git a/LayoutTests/fast/dom/Document/document-charset.html b/LayoutTests/fast/dom/Document/document-charset.html
index fffc724ea39d86330c8e810ead12a36078f8b93a..1594696cec89c1833103bedc6097a81f01c19cd2 100644
--- a/LayoutTests/fast/dom/Document/document-charset.html
+++ b/LayoutTests/fast/dom/Document/document-charset.html
@@ -15,28 +15,12 @@ document.write("<p>&nbsp;document.defaultCharset: " + (document.defaultCharset ?
document.write("<p>&nbsp;document.characterSet: " + document.characterSet + "</p>"); // Firefox
document.write("<p>&nbsp;document.inputEncoding: " + document.inputEncoding + "</p>"); // DOM3
-document.write("<p>Setting charset to UTF-8...</p>");
-try {
- document.charset = "utf-8";
- document.write("<p>&nbsp;document.charset: " + document.charset + "</p>");
- document.write("<p>&nbsp;document.defaultCharset: " + (document.defaultCharset ? "defined" : "undefined") + "</p>");
- document.write("<p>&nbsp;document.characterSet: " + document.characterSet + "</p>");
- document.write("<p>&nbsp;document.inputEncoding: " + document.inputEncoding + "</p>");
-} catch (ex) {
- document.write("<p>Failure</p>");
-}
-
-// throws an exception in Firefox, but JavaScriptCore seems to silently ignore assignment to read-only properties
-document.write("<p>Setting characterSet to KOI8-R (expected to fail, matching Firefox)...</p>");
-try {
- document.characterSet = "KOI8-R";
- document.write("<p>&nbsp;document.charset: " + document.charset + "</p>");
- document.write("<p>&nbsp;document.defaultCharset: " + (document.defaultCharset ? "defined" : "undefined") + "</p>");
- document.write("<p>&nbsp;document.characterSet: " + document.characterSet + "</p>");
- document.write("<p>&nbsp;document.inputEncoding: " + document.inputEncoding + "</p>");
-} catch (ex) {
- document.write("<p>Failure (expected)</p>");
-}
+document.write("<p>Setting charset to UTF-8... (expected to have no effect)</p>");
+document.charset = "utf-8";
+document.write("<p>&nbsp;document.charset: " + document.charset + "</p>");
+document.write("<p>&nbsp;document.defaultCharset: " + (document.defaultCharset ? "defined" : "undefined") + "</p>");
+document.write("<p>&nbsp;document.characterSet: " + document.characterSet + "</p>");
+document.write("<p>&nbsp;document.inputEncoding: " + document.inputEncoding + "</p>");
</script>
</body>
« no previous file with comments | « no previous file | LayoutTests/fast/dom/Document/document-charset-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698