Override OnSSLCertificateError() in connectivity_checker.

Override OnSSLCertificateError() in connectivity_checker.

By default, OnSSLCertificateError() just cancels current request.
For connectivity_checker, it needs to cancel the current request
and starts next check. In particular, this handles the case that
SSL cert fails when device system time is changing (syncing to
NTP server).

BUG=internal b/20775908

Committed: https://crrev.com/fce5824251e2493f75cecea585248e63000b6ac7
Cr-Commit-Position: refs/heads/master@{#330557}

[wzhong, 2015-05-19 05:09:38]

wzhong@chromium.org changed reviewers:
+ byungchul@chromium.org, derekjchow@chromium.org, lcwu@chromium.org

[derekjchow1, 2015-05-19 17:08:47]

LGTM % a couple nits.

https://codereview.chromium.org/1145723004/diff/20001/chromecast/net/connecti...
File chromecast/net/connectivity_checker.cc (right):

https://codereview.chromium.org/1145723004/diff/20001/chromecast/net/connecti...
chromecast/net/connectivity_checker.cc:165: LOG(ERROR) <<
"OnSSLCertificateError";
Would VLOG be more appropriate (how often will this occur? How severe is the
problem when it does occur?)?

https://codereview.chromium.org/1145723004/diff/20001/chromecast/net/connecti...
File chromecast/net/connectivity_checker.h (right):

https://codereview.chromium.org/1145723004/diff/20001/chromecast/net/connecti...
chromecast/net/connectivity_checker.h:72: void OnUrlRequestError();
Move this away from URLRequest::Delegate methods. It looks like it's overriding
some method.

[wzhong, 2015-05-19 17:27:05]

https://codereview.chromium.org/1145723004/diff/20001/chromecast/net/connecti...
File chromecast/net/connectivity_checker.cc (right):

https://codereview.chromium.org/1145723004/diff/20001/chromecast/net/connecti...
chromecast/net/connectivity_checker.cc:165: LOG(ERROR) <<
"OnSSLCertificateError";
On 2015/05/19 17:08:47, derekjchow1 wrote:
> Would VLOG be more appropriate (how often will this occur? How severe is the
> problem when it does occur?)?

It should be happening in very rare circumstances that Internet is connected
while time syncing is ongoing.

https://codereview.chromium.org/1145723004/diff/20001/chromecast/net/connecti...
File chromecast/net/connectivity_checker.h (right):

https://codereview.chromium.org/1145723004/diff/20001/chromecast/net/connecti...
chromecast/net/connectivity_checker.h:72: void OnUrlRequestError();
On 2015/05/19 17:08:47, derekjchow1 wrote:
> Move this away from URLRequest::Delegate methods. It looks like it's
overriding
> some method.

Done.

[gunsch, 2015-05-19 17:42:22]

gunsch@chromium.org changed reviewers:
+ gunsch@chromium.org

[gunsch, 2015-05-19 17:42:22]

lgtm

[wzhong, 2015-05-19 17:49:20]

The CQ bit was checked by wzhong@chromium.org

[wzhong, 2015-05-19 17:49:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
derekjchow@chromium.org
Link to the patchset: https://codereview.chromium.org/1145723004/#ps40001
(title: "Handle OnSSLCertificateError() in connectivity_checker.")

[commit-bot: I haz the power, 2015-05-19 17:50:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1145723004/40001

[commit-bot: I haz the power, 2015-05-19 18:06:51]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-05-19 18:08:42]

Patchset 3 (id:??) landed as
https://crrev.com/fce5824251e2493f75cecea585248e63000b6ac7
Cr-Commit-Position: refs/heads/master@{#330557}