Override OnSSLCertificateError() in connectivity_checker.

chromecast/net/connectivity_checker.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROMECAST_NET_CONNECTIVITY_CHECKER_H_
 #define CHROMECAST_NET_CONNECTIVITY_CHECKER_H_
 
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
 #include "net/base/network_change_notifier.h"
 #include "net/url_request/url_request.h"
 
 class GURL;
 
 namespace base {
 class MessageLoopProxy;
 }
 
 namespace net {
+class SSLInfo;
 class URLRequestContext;
 }
 
 namespace chromecast {
 
 // Simple class to check network connectivity by sending a HEAD http request
 // to given url.
 class ConnectivityChecker
     : public base::RefCountedThreadSafe<ConnectivityChecker>,
       public net::URLRequest::Delegate,
@@ skipping 27 matching lines @@
 
  protected:
   ~ConnectivityChecker() override;
 
  private:
   friend class base::RefCountedThreadSafe<ConnectivityChecker>;
 
   // UrlRequest::Delegate implementation:
   void OnResponseStarted(net::URLRequest* request) override;
   void OnReadCompleted(net::URLRequest* request, int bytes_read) override;
+  void OnSSLCertificateError(net::URLRequest* request,
+                             const net::SSLInfo& ssl_info,
+                             bool fatal) override;
+  void OnUrlRequestError();

[derekjchow1, 2015/05/19 17:08:47]

Move this away from URLRequest::Delegate methods. It looks like it's overriding
some method.

[wzhong, 2015/05/19 17:27:05]

Done.

 
   // Initializes ConnectivityChecker
   void Initialize();
 
   // NetworkChangeNotifier::ConnectionTypeObserver implementation:
   void OnConnectionTypeChanged(
       net::NetworkChangeNotifier::ConnectionType type) override;
 
   // net::NetworkChangeNotifier::IPAddressObserver implementation:
   void OnIPAddressChanged() override;
 
   // Cancels current connectivity checking in progress.
   void Cancel();
 
   // Sets connectivity and alerts observers if it has changed
   void SetConnectivity(bool connected);
 
   scoped_ptr<GURL> connectivity_check_url_;
   scoped_ptr<net::URLRequestContext> url_request_context_;
   scoped_ptr<net::URLRequest> url_request_;
   const scoped_refptr<ObserverListThreadSafe<ConnectivityObserver> >
       connectivity_observer_list_;
   const scoped_refptr<base::MessageLoopProxy> loop_proxy_;
   bool connected_;
-  unsigned int bad_responses_;
+  // Number of connectivity check errors.
+  unsigned int check_errors_;
 
   DISALLOW_COPY_AND_ASSIGN(ConnectivityChecker);
 };
 
 }  // namespace chromecast
 
 #endif  // CHROMECAST_NET_CONNECTIVITY_CHECKER_H_