Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1145723003:
Add bot config for ClangToTiOS (Closed)
DescriptionAdd bot config for ClangToTiOS
BUG=452726
Committed: https://crrev.com/7af1026772874f47b4c81bf353e7bd92ca8c1f15
Cr-Commit-Position: refs/heads/master@{#330767}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Add werror and clang_use_chrome_plugins to GYP_DEFINES #
Total comments: 2
Patch Set 3 : alphabetize #
Total comments: 2
Patch Set 4 : Try putting LLVM_FORCE_HEAD_REVISION in env #
Total comments: 2
Messages
Total messages: 30 (7 generated)
hans@chromium.org changed reviewers: + smut@google.com, thakis@chromium.org
Please take a look. Follow-up from https://codereview.chromium.org/1139063004/#msg9
https://codereview.chromium.org/1145723003/diff/1/ios/build/bots/chromium.fyi... File ios/build/bots/chromium.fyi/ClangToTiOS.json (right): https://codereview.chromium.org/1145723003/diff/1/ios/build/bots/chromium.fyi... ios/build/bots/chromium.fyi/ClangToTiOS.json:12: "LLVM_FORCE_HEAD_REVISION": "YES" What about clang_use_chrome_plugins=0? werror=""? You seemed to want those.
Please take another look. https://codereview.chromium.org/1145723003/diff/1/ios/build/bots/chromium.fyi... File ios/build/bots/chromium.fyi/ClangToTiOS.json (right): https://codereview.chromium.org/1145723003/diff/1/ios/build/bots/chromium.fyi... ios/build/bots/chromium.fyi/ClangToTiOS.json:12: "LLVM_FORCE_HEAD_REVISION": "YES" On 2015/05/19 00:04:49, smut wrote: > What about clang_use_chrome_plugins=0? werror=""? You seemed to want those. Done.
lgtm % comment https://codereview.chromium.org/1145723003/diff/20001/ios/build/bots/chromium... File ios/build/bots/chromium.fyi/ClangToTiOS.json (right): https://codereview.chromium.org/1145723003/diff/20001/ios/build/bots/chromium... ios/build/bots/chromium.fyi/ClangToTiOS.json:14: "LLVM_FORCE_HEAD_REVISION": "YES" I'd probably alphabetize these.
Thanks! https://codereview.chromium.org/1145723003/diff/20001/ios/build/bots/chromium... File ios/build/bots/chromium.fyi/ClangToTiOS.json (right): https://codereview.chromium.org/1145723003/diff/20001/ios/build/bots/chromium... ios/build/bots/chromium.fyi/ClangToTiOS.json:14: "LLVM_FORCE_HEAD_REVISION": "YES" On 2015/05/19 00:11:11, smut wrote: > I'd probably alphabetize these. Done.
The CQ bit was checked by hans@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from smut@google.com Link to the patchset: https://codereview.chromium.org/1145723003/#ps40001 (title: "alphabetize")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145723003/40001
The CQ bit was unchecked by commit-bot@chromium.org
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an LGTM may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
https://codereview.chromium.org/1145723003/diff/40001/ios/build/bots/chromium... File ios/build/bots/chromium.fyi/ClangToTiOS.json (right): https://codereview.chromium.org/1145723003/diff/40001/ios/build/bots/chromium... ios/build/bots/chromium.fyi/ClangToTiOS.json:12: "LLVM_FORCE_HEAD_REVISION": "YES", is this a gyp define? you need this as env var, no?
On 2015/05/19 00:13:52, I haz the power (commit-bot) wrote: > No LGTM from a valid reviewer yet. Only full committers are accepted. > Even if an LGTM may have been provided, it was from a non-committer, > _not_ a full super star committer. I thought smut was full super star committer :-) thakis?
New patch uploaded. https://codereview.chromium.org/1145723003/diff/40001/ios/build/bots/chromium... File ios/build/bots/chromium.fyi/ClangToTiOS.json (right): https://codereview.chromium.org/1145723003/diff/40001/ios/build/bots/chromium... ios/build/bots/chromium.fyi/ClangToTiOS.json:12: "LLVM_FORCE_HEAD_REVISION": "YES", On 2015/05/19 00:16:17, Nico wrote: > is this a gyp define? you need this as env var, no? You're right. I don't know what consumes this json but let's try putting it in 'env'.
Probably https://codereview.chromium.org/908053002/diff/20001/scripts/slave/recipe_mod... ? Looking at the code there, it doesn't look like there's an existing entry to override env – I guess you need to change that file first?
smut@google.com changed reviewers: + sdefresne@chromium.org
Is LLVM_FORCE_HEAD_REVISION=YES to make it use ToT clang? I think clang_xcode=0 will do that. +sdefresne for more info. https://codereview.chromium.org/1145723003/diff/60001/ios/build/bots/chromium... File ios/build/bots/chromium.fyi/ClangToTiOS.json (right): https://codereview.chromium.org/1145723003/diff/60001/ios/build/bots/chromium... ios/build/bots/chromium.fyi/ClangToTiOS.json:16: "LLVM_FORCE_HEAD_REVISION": "YES" This won't work unless you make it work. See https://chromium.googlesource.com/chromium/tools/build/+/master/scripts/slave....
On 2015/05/19 00:29:23, smut wrote: > Is LLVM_FORCE_HEAD_REVISION=YES to make it use ToT clang? I think clang_xcode=0 > will do that. +sdefresne for more info. No, it's to force tools/clang/scripts/update.sh to build head clang instead of our prebuilt chromium clang that's "almost head". clang_xcode=0 enables the prebuilts.
https://codereview.chromium.org/1145723003/diff/60001/ios/build/bots/chromium... File ios/build/bots/chromium.fyi/ClangToTiOS.json (right): https://codereview.chromium.org/1145723003/diff/60001/ios/build/bots/chromium... ios/build/bots/chromium.fyi/ClangToTiOS.json:16: "LLVM_FORCE_HEAD_REVISION": "YES" On 2015/05/19 00:29:23, smut wrote: > This won't work unless you make it work. See > https://chromium.googlesource.com/chromium/tools/build/+/master/scripts/slave.... Trying this in https://codereview.chromium.org/1145733003
thakis: Does this look ok given the build-tools side patch?
On 2015/05/20 00:29:05, hans wrote: > thakis: Does this look ok given the build-tools side patch? thakis: Ping for when you have a spare moment.
On 2015/05/20 15:46:31, hans wrote: > On 2015/05/20 00:29:05, hans wrote: > > thakis: Does this look ok given the build-tools side patch? > > thakis: Ping for when you have a spare moment. Lgtm (sorry, on phone today)
The CQ bit was checked by hans@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from smut@google.com Link to the patchset: https://codereview.chromium.org/1145723003/#ps60001 (title: "Try putting LLVM_FORCE_HEAD_REVISION in env")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145723003/60001
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/7af1026772874f47b4c81bf353e7bd92ca8c1f15 Cr-Commit-Position: refs/heads/master@{#330767}
Message was sent while issue was closed.
smut: Thanks for your help in reviewing this! The bot is now failing the "find xcode" step: http://build.chromium.org/p/chromium.fyi/builders/ClangToTiOS/builds/43/steps... I'm not sure how to parse the output. It seems to find XCode 5.1.1, but it's not happy? Do we need to install some specific version of xcode on this machine?
Message was sent while issue was closed.
On 2015/05/20 21:18:55, hans wrote: > smut: Thanks for your help in reviewing this! > > The bot is now failing the "find xcode" step: > http://build.chromium.org/p/chromium.fyi/builders/ClangToTiOS/builds/43/steps... > > I'm not sure how to parse the output. It seems to find XCode 5.1.1, but it's not > happy? > > Do we need to install some specific version of xcode on this machine? The config says Xcode 6.2, but this machine only has 5.1.1, so it needs to be reimaged. Actually, the config should be updated to 6.3 now. I'll update the config, and I've filed https://crbug.com/490355 for the machine.
Message was sent while issue was closed.
On 2015/05/20 21:30:35, smut wrote: > On 2015/05/20 21:18:55, hans wrote: > > smut: Thanks for your help in reviewing this! > > > > The bot is now failing the "find xcode" step: > > > http://build.chromium.org/p/chromium.fyi/builders/ClangToTiOS/builds/43/steps... > > > > I'm not sure how to parse the output. It seems to find XCode 5.1.1, but it's > not > > happy? > > > > Do we need to install some specific version of xcode on this machine? > > The config says Xcode 6.2, but this machine only has 5.1.1, so it needs to be > reimaged. Actually, the config should be updated to 6.3 now. I'll update the > config, and I've filed https://crbug.com/490355 for the machine. Awesome, thanks! |
