Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1145733003: ios: Allow bot configs to set extra env variables (Closed)

Created:
5 years, 7 months ago by hans
Modified:
5 years, 7 months ago
Reviewers:
Nico, smut
CC:
chromium-reviews, kjellander-cc_chromium.org, stip+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

ios: Allow bot configs to set extra env variables BUG=452726 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295329

Patch Set 1 #

Total comments: 2

Patch Set 2 : Provide a default self.__config['env'] #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -17 lines) Patch
M scripts/slave/recipe_modules/ios/api.py View 1 2 chunks +8 lines, -5 lines 0 comments Download
M scripts/slave/recipe_modules/ios/example.expected/basic.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/ios/example.expected/clobber.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/ios/try.expected/basic.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/ios/try.expected/parent.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/ios/try.expected/without_patch_failure.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/ios/try.expected/without_patch_success.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/ios/unified_builder_tester.py View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/ios/unified_builder_tester.expected/basic.json View 3 chunks +8 lines, -2 lines 0 comments Download
M scripts/slave/recipes/ios/unified_builder_tester.expected/infrastructure_failure.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/ios/unified_builder_tester.expected/multiple_failures.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/ios/unified_builder_tester.expected/no_tests.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/ios/unified_builder_tester.expected/test_failure.json View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
hans
Please take a look.
5 years, 7 months ago (2015-05-19 16:09:33 UTC) #2
smut
lgtm % comment https://codereview.chromium.org/1145733003/diff/1/scripts/slave/recipe_modules/ios/api.py File scripts/slave/recipe_modules/ios/api.py (right): https://codereview.chromium.org/1145733003/diff/1/scripts/slave/recipe_modules/ios/api.py#newcode228 scripts/slave/recipe_modules/ios/api.py:228: env.update(self.__config.get('env', {})) In read_build_config, please add ...
5 years, 7 months ago (2015-05-19 19:52:08 UTC) #3
hans
Thanks for the review! https://codereview.chromium.org/1145733003/diff/1/scripts/slave/recipe_modules/ios/api.py File scripts/slave/recipe_modules/ios/api.py (right): https://codereview.chromium.org/1145733003/diff/1/scripts/slave/recipe_modules/ios/api.py#newcode228 scripts/slave/recipe_modules/ios/api.py:228: env.update(self.__config.get('env', {})) On 2015/05/19 19:52:08, ...
5 years, 7 months ago (2015-05-19 20:11:45 UTC) #4
hans
thakis: Ping
5 years, 7 months ago (2015-05-20 15:46:50 UTC) #5
Nico
On 2015/05/20 15:46:50, hans wrote: > thakis: Ping Rs-lgtm
5 years, 7 months ago (2015-05-20 16:05:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145733003/20001
5 years, 7 months ago (2015-05-20 16:08:42 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 16:13:09 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=295329

Powered by Google App Engine
This is Rietveld 408576698