Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Issue 1145703002: Fixed SEGV that could happen if an exception is thrown during bootstrapping. (Closed)

Created:
5 years, 7 months ago by Igor Sheludko
Modified:
5 years, 7 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fixed SEGV that could happen if an exception is thrown during bootstrapping. BUG=chromium:487974 LOG=N Committed: https://crrev.com/5bd4f9dd5a7f27042acbf845b3f84a32bc6c179e Cr-Commit-Position: refs/heads/master@{#28453}

Patch Set 1 #

Patch Set 2 : Rebasing #

Patch Set 3 : Rebasing #@$! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/bootstrapper.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Igor Sheludko
PTAL
5 years, 7 months ago (2015-05-18 14:40:49 UTC) #2
Michael Starzinger
LGTM.
5 years, 7 months ago (2015-05-18 14:46:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145703002/1
5 years, 7 months ago (2015-05-18 14:47:23 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/447)
5 years, 7 months ago (2015-05-18 14:49:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145703002/40001
5 years, 7 months ago (2015-05-18 15:01:36 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-18 15:50:43 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 15:51:01 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5bd4f9dd5a7f27042acbf845b3f84a32bc6c179e
Cr-Commit-Position: refs/heads/master@{#28453}

Powered by Google App Engine
This is Rietveld 408576698