src/bootstrapper.cc - Issue 1145703002: Fixed SEGV that could happen if an exception is thrown during bootstrapping.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/bootstrapper.cc

Issue 1145703002: Fixed SEGV that could happen if an exception is thrown during bootstrapping. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Rebasing #@$! Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/bootstrapper.cc

diff --git a/src/bootstrapper.cc b/src/bootstrapper.cc

index 21f3ec0e2b71432b82cb9d96543d84595332abcd..713dbb3af1a9cda012b180d2cd9d3eac3ee791ac 100644

--- a/src/bootstrapper.cc

+++ b/src/bootstrapper.cc

@@ -1495,6 +1495,7 @@ bool Genesis::CompileNative(Isolate* isolate, Vector<const char> name,

Handle<SharedFunctionInfo> function_info = Compiler::CompileScript(

source, script_name, 0, 0, false, false, Handle<Object>(), context, NULL,

NULL, ScriptCompiler::kNoCompileOptions, NATIVES_CODE, false);

+ if (function_info.is_null()) return false;

DCHECK(context->IsNativeContext());

« no previous file with comments | « no previous file | no next file » | no next file with comments »