Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 1145653002: Web MIDI ALSA: Enable hardware based device matching (Closed)

Created:
5 years, 7 months ago by Adam Goode
Modified:
5 years, 7 months ago
Reviewers:
Takashi Toyoshima
CC:
chromium-reviews, feature-media-reviews_chromium.org, toyoshim+midi_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@magical-sound-shower
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Web MIDI ALSA: Enable hardware based device matching BUG=486471 Committed: https://crrev.com/774a30f2010327ae6a94ea2a8bb57d030161b0da Cr-Commit-Position: refs/heads/master@{#330941}

Patch Set 1 #

Patch Set 2 : Update comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+216 lines, -115 lines) Patch
M media/midi/midi_manager_alsa.h View 1 5 chunks +62 lines, -29 lines 0 comments Download
M media/midi/midi_manager_alsa.cc View 6 chunks +79 lines, -42 lines 0 comments Download
M media/midi/midi_manager_alsa_unittest.cc View 3 chunks +75 lines, -44 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Adam Goode
5 years, 7 months ago (2015-05-21 01:38:33 UTC) #2
Takashi Toyoshima
lgtm
5 years, 7 months ago (2015-05-21 15:01:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145653002/20001
5 years, 7 months ago (2015-05-21 15:21:51 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-21 15:29:41 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-21 15:30:32 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/774a30f2010327ae6a94ea2a8bb57d030161b0da
Cr-Commit-Position: refs/heads/master@{#330941}

Powered by Google App Engine
This is Rietveld 408576698