Web MIDI ALSA: Enable hardware based device matching

media/midi/midi_manager_alsa_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/midi/midi_manager_alsa.h"
 
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace media {
 namespace midi {
 
 class MidiManagerAlsaTest : public ::testing::Test {
  protected:
   void SetUp() override {
     // Pre-instantiate typical MidiPort instances that are often used in
     // following tests.
 
     // Inputs. port_input_0_ == port_input_1_.
     port_input_0_.reset(new MidiManagerAlsa::MidiPort(
-        "path", "id", 1, 2, 5, "client_name", "port_name", "manufacturer",
-        "version", MidiManagerAlsa::MidiPort::Type::kInput));
+        "path", MidiManagerAlsa::MidiPort::Id("bus", "vendor", "model",
+                                              "interface", "serial"),
+        1, 2, 5, "client_name", "port_name", "manufacturer", "version",
+        MidiManagerAlsa::MidiPort::Type::kInput));
     port_input_1_.reset(new MidiManagerAlsa::MidiPort(
-        "path", "id", 1, 2, 5, "client_name", "port_name", "manufacturer",
-        "version", MidiManagerAlsa::MidiPort::Type::kInput));
-    port_input_minimal_.reset(
-        new MidiManagerAlsa::MidiPort("", "", 0, 0, 0, "", "", "", "",
-                                      MidiManagerAlsa::MidiPort::Type::kInput));
+        "path", MidiManagerAlsa::MidiPort::Id("bus", "vendor", "model",
+                                              "interface", "serial"),
+        1, 2, 5, "client_name", "port_name", "manufacturer", "version",
+        MidiManagerAlsa::MidiPort::Type::kInput));
+    port_input_minimal_.reset(new MidiManagerAlsa::MidiPort(
+        "", MidiManagerAlsa::MidiPort::Id(), 0, 0, 0, "", "", "", "",
+        MidiManagerAlsa::MidiPort::Type::kInput));
     // Outputs. port_output_0_ == port_output_1_.
     port_output_0_.reset(new MidiManagerAlsa::MidiPort(
-        "path", "id", 1, 2, 5, "client_name", "port_name", "manufacturer",
-        "version", MidiManagerAlsa::MidiPort::Type::kOutput));
+        "path", MidiManagerAlsa::MidiPort::Id("bus", "vendor", "model",
+                                              "interface", "serial"),
+        1, 2, 5, "client_name", "port_name", "manufacturer", "version",
+        MidiManagerAlsa::MidiPort::Type::kOutput));
     port_output_1_.reset(new MidiManagerAlsa::MidiPort(
-        "path", "id", 1, 2, 5, "client_name", "port_name", "manufacturer",
-        "version", MidiManagerAlsa::MidiPort::Type::kOutput));
+        "path", MidiManagerAlsa::MidiPort::Id("bus", "vendor", "model",
+                                              "interface", "serial"),
+        1, 2, 5, "client_name", "port_name", "manufacturer", "version",
+        MidiManagerAlsa::MidiPort::Type::kOutput));
 
     // MidiPort fields that differ from port_input_0_ in a single way each time.
     // Used for testing the Match* and Find* methods.
     port_input_0_alt_path_.reset(new MidiManagerAlsa::MidiPort(
-        "path2", "id", 1, 2, 5, "client_name", "port_name", "manufacturer",
-        "version", MidiManagerAlsa::MidiPort::Type::kInput));
+        "path2", MidiManagerAlsa::MidiPort::Id("bus", "vendor", "model",
+                                               "interface", "serial"),
+        1, 2, 5, "client_name", "port_name", "manufacturer", "version",
+        MidiManagerAlsa::MidiPort::Type::kInput));
     port_input_0_alt_id_.reset(new MidiManagerAlsa::MidiPort(
-        "path", "id2", 1, 2, 5, "client_name", "port_name", "manufacturer",
-        "version", MidiManagerAlsa::MidiPort::Type::kInput));
+        "path", MidiManagerAlsa::MidiPort::Id("bus", "vendor", "model",
+                                              "interface", "serial2"),
+        1, 2, 5, "client_name", "port_name", "manufacturer", "version",
+        MidiManagerAlsa::MidiPort::Type::kInput));
     port_input_0_alt_client_name_.reset(new MidiManagerAlsa::MidiPort(
-        "path", "id", 1, 2, 5, "client_name2", "port_name", "manufacturer",
-        "version", MidiManagerAlsa::MidiPort::Type::kInput));
+        "path", MidiManagerAlsa::MidiPort::Id("bus", "vendor", "model",
+                                              "interface", "serial"),
+        1, 2, 5, "client_name2", "port_name", "manufacturer", "version",
+        MidiManagerAlsa::MidiPort::Type::kInput));
     port_input_0_alt_port_name_.reset(new MidiManagerAlsa::MidiPort(
-        "path", "id", 1, 2, 5, "client_name", "port_name2", "manufacturer",
-        "version", MidiManagerAlsa::MidiPort::Type::kInput));
+        "path", MidiManagerAlsa::MidiPort::Id("bus", "vendor", "model",
+                                              "interface", "serial"),
+        1, 2, 5, "client_name", "port_name2", "manufacturer", "version",
+        MidiManagerAlsa::MidiPort::Type::kInput));
     port_input_0_alt_client_id_.reset(new MidiManagerAlsa::MidiPort(
-        "path", "id", 2, 2, 5, "client_name", "port_name", "manufacturer",
-        "version", MidiManagerAlsa::MidiPort::Type::kInput));
+        "path", MidiManagerAlsa::MidiPort::Id("bus", "vendor", "model",
+                                              "interface", "serial"),
+        2, 2, 5, "client_name", "port_name", "manufacturer", "version",
+        MidiManagerAlsa::MidiPort::Type::kInput));
     port_input_0_alt_port_id_.reset(new MidiManagerAlsa::MidiPort(
-        "path", "id", 1, 3, 5, "client_name", "port_name", "manufacturer",
-        "version", MidiManagerAlsa::MidiPort::Type::kInput));
+        "path", MidiManagerAlsa::MidiPort::Id("bus", "vendor", "model",
+                                              "interface", "serial"),
+        1, 3, 5, "client_name", "port_name", "manufacturer", "version",
+        MidiManagerAlsa::MidiPort::Type::kInput));
     port_input_0_alt_midi_device_.reset(new MidiManagerAlsa::MidiPort(
-        "path", "id", 1, 2, 6, "client_name", "port_name", "manufacturer",
-        "version", MidiManagerAlsa::MidiPort::Type::kInput));
+        "path", MidiManagerAlsa::MidiPort::Id("bus", "vendor", "model",
+                                              "interface", "serial"),
+        1, 2, 6, "client_name", "port_name", "manufacturer", "version",
+        MidiManagerAlsa::MidiPort::Type::kInput));
 
     // "No card" variants of above. For testing FindDisconnected.
     port_input_0_no_card_.reset(new MidiManagerAlsa::MidiPort(
-        "", "", 1, 2, -1, "client_name", "port_name", "manufacturer", "version",
+        "", MidiManagerAlsa::MidiPort::Id(), 1, 2, -1, "client_name",
+        "port_name", "manufacturer", "version",
         MidiManagerAlsa::MidiPort::Type::kInput));
     port_input_1_no_card_.reset(new MidiManagerAlsa::MidiPort(
-        "", "", 1, 2, -1, "client_name", "port_name", "manufacturer", "version",
+        "", MidiManagerAlsa::MidiPort::Id(), 1, 2, -1, "client_name",
+        "port_name", "manufacturer", "version",
         MidiManagerAlsa::MidiPort::Type::kInput));
     port_output_0_no_card_.reset(new MidiManagerAlsa::MidiPort(
-        "", "", 1, 2, -1, "client_name", "port_name", "manufacturer", "version",
+        "", MidiManagerAlsa::MidiPort::Id(), 1, 2, -1, "client_name",
+        "port_name", "manufacturer", "version",
         MidiManagerAlsa::MidiPort::Type::kOutput));
 
     // No card variants of the alt variants from above. For more testing
     // of Match* and Find*.
     port_input_0_no_card_alt_client_name_.reset(new MidiManagerAlsa::MidiPort(
-        "", "", 1, 2, -1, "client_name2", "port_name", "manufacturer",
-        "version", MidiManagerAlsa::MidiPort::Type::kInput));
+        "", MidiManagerAlsa::MidiPort::Id(), 1, 2, -1, "client_name2",
+        "port_name", "manufacturer", "version",
+        MidiManagerAlsa::MidiPort::Type::kInput));
     port_input_0_no_card_alt_port_name_.reset(new MidiManagerAlsa::MidiPort(
-        "", "", 1, 2, -1, "client_name", "port_name2", "manufacturer",
-        "version", MidiManagerAlsa::MidiPort::Type::kInput));
+        "", MidiManagerAlsa::MidiPort::Id(), 1, 2, -1, "client_name",
+        "port_name2", "manufacturer", "version",
+        MidiManagerAlsa::MidiPort::Type::kInput));
     port_input_0_no_card_alt_client_id_.reset(new MidiManagerAlsa::MidiPort(
-        "", "", 2, 2, -1, "client_name", "port_name", "manufacturer", "version",
+        "", MidiManagerAlsa::MidiPort::Id(), 2, 2, -1, "client_name",
+        "port_name", "manufacturer", "version",
         MidiManagerAlsa::MidiPort::Type::kInput));
     port_input_0_no_card_alt_port_id_.reset(new MidiManagerAlsa::MidiPort(
-        "", "", 1, 3, -1, "client_name", "port_name", "manufacturer", "version",
+        "", MidiManagerAlsa::MidiPort::Id(), 1, 3, -1, "client_name",
+        "port_name", "manufacturer", "version",
         MidiManagerAlsa::MidiPort::Type::kInput));
   }
 
   // Counts ports for help with testing ToMidiPortState().
   int CountPorts(MidiManagerAlsa::TemporaryMidiPortState& state) {
     int count = 0;
     for (auto it = state.begin(); it != state.end(); ++it)
       ++count;
     return count;
   }
@@ skipping 79 matching lines @@
   EXPECT_EQ("C-Media Electronics Inc",
             MidiManagerAlsa::AlsaCard::ExtractManufacturerString(
                 "", "0x13f6", "C-Media Electronics Inc", "C-Media CMI8738 FM",
                 "C-Media CMI8738 (model 55) at 0xd000, irq 19"));
 }
 
 // Tests that verify proper serialization and generation of opaque key for
 // MidiPort.
 TEST_F(MidiManagerAlsaTest, JSONPortMetadata) {
   EXPECT_EQ(
-      "{\"clientId\":1,\"clientName\":\"client_name\",\"id\":\"id\","
-      "\"midiDevice\":5,\"path\":\"path\",\"portId\":2,\"portName\":\"port_"
-      "name\",\"type\":\"input\"}",
+      "{\"bus\":\"bus\",\"clientId\":1,\"clientName\":\"client_name\","
+      "\"midiDevice\":5,\"modelId\":\"model\",\"path\":\"path\",\"portId\":2,"
+      "\"portName\":\"port_name\",\"serial\":\"serial\",\"type\":\"input\","
+      "\"usbInterfaceNum\":\"interface\",\"vendorId\":\"vendor\"}",
       port_input_0_->JSONValue());
 
-  EXPECT_EQ("03F255B7EE4D9D061597289CB16B45F997DBDB20D8E44429B052019C84E20A4A",
+  EXPECT_EQ("810194DAF713B32FC9BE40EC822E21682635B48C242D09EA95DBA4A184A95877",
             port_input_0_->OpaqueKey());
 
   EXPECT_EQ(
-      "{\"clientId\":1,\"clientName\":\"client_name\",\"id\":\"id\","
-      "\"midiDevice\":5,\"path\":\"path\",\"portId\":2,\"portName\":\"port_"
-      "name\",\"type\":\"output\"}",
+      "{\"bus\":\"bus\",\"clientId\":1,\"clientName\":\"client_name\","
+      "\"midiDevice\":5,\"modelId\":\"model\",\"path\":\"path\",\"portId\":2,"
+      "\"portName\":\"port_name\",\"serial\":\"serial\",\"type\":\"output\","
+      "\"usbInterfaceNum\":\"interface\",\"vendorId\":\"vendor\"}",
       port_output_0_->JSONValue());
-  EXPECT_EQ("3A3380FD64B8C79900C052D64C3F52E9ECD6537D00ECB02B8FA30032C0C03924",
+  EXPECT_EQ("C32552FC772A0CA453A675CED05EFB3BDEF749EB58ED9522475206F111BC01E2",
             port_output_0_->OpaqueKey());
 
   EXPECT_EQ("{\"clientId\":0,\"midiDevice\":0,\"portId\":0,\"type\":\"input\"}",
             port_input_minimal_->JSONValue());
   EXPECT_EQ("3BC2A85598E5026D01DBCB022016C8A3362A9C7F912B88E303BF619C56D0C111",
             port_input_minimal_->OpaqueKey());
 }
 
 // Tests Match* methods.
 TEST_F(MidiManagerAlsaTest, MatchConnected) {
@@ skipping 391 matching lines @@
             CountPorts(*alsa_seq_state_0_.ToMidiPortState(alsa_cards_).get()));
 
   // Remove a non-existent port. No change.
   alsa_seq_state_0_.PortExit(0, 0);
   EXPECT_EQ(1,
             CountPorts(*alsa_seq_state_0_.ToMidiPortState(alsa_cards_).get()));
 
   // Verify the last entry.
   EXPECT_TRUE((*alsa_seq_state_0_.ToMidiPortState(alsa_cards_)->begin())
                   ->MatchConnected(MidiManagerAlsa::MidiPort(
-                      "", "", 0, 1, -1, "0", "0:1", "", "",
-                      MidiManagerAlsa::MidiPort::Type::kOutput)));
+                      "", MidiManagerAlsa::MidiPort::Id(), 0, 1, -1, "0", "0:1",
+                      "", "", MidiManagerAlsa::MidiPort::Type::kOutput)));
 }
 
 // Tests card_client_count of AlsaSeqState.
 TEST_F(MidiManagerAlsaTest, CardClientCount) {
   EXPECT_EQ(0, alsa_seq_state_0_.card_client_count());
 
   // Add a kernel client.
   alsa_seq_state_0_.ClientStart(16, "16", SND_SEQ_KERNEL_CLIENT);
   EXPECT_EQ(1, alsa_seq_state_0_.card_client_count());
 
@@ skipping 40 matching lines @@
 }
 
 TEST_F(MidiManagerAlsaTest, AlsaCards) {
   // TODO(agoode): test add/remove of alsa cards.
 }
 
 // TODO(agoode): Test old -> new state event generation, using mocks.
 
 }  // namespace midi
 }  // namespace media