Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1145553002: Add extra crash logging for starting the sink with no frames. (Closed)

Created:
5 years, 7 months ago by DaleCurtis
Modified:
5 years, 7 months ago
Reviewers:
xhwang
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add extra crash logging for starting the sink with no frames. Crash on the compositor thread is too late to debug effectively, so cause crashes earlier. BUG=485324 TEST=none TBR=xhwang Committed: https://crrev.com/707ffafaa4635ce560dc6f3cc0d909c6d7e8618c Cr-Commit-Position: refs/heads/master@{#330026}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M media/renderers/video_renderer_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
DaleCurtis
5 years, 7 months ago (2015-05-15 01:02:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145553002/1
5 years, 7 months ago (2015-05-15 01:03:54 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-15 02:43:32 UTC) #4
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 02:44:18 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/707ffafaa4635ce560dc6f3cc0d909c6d7e8618c
Cr-Commit-Position: refs/heads/master@{#330026}

Powered by Google App Engine
This is Rietveld 408576698