media/renderers/video_renderer_impl.cc - Issue 1145553002: Add extra crash logging for starting the sink with no frames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/renderers/video_renderer_impl.cc

Issue 1145553002: Add extra crash logging for starting the sink with no frames. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/renderers/video_renderer_impl.cc

diff --git a/media/renderers/video_renderer_impl.cc b/media/renderers/video_renderer_impl.cc

index 0e3e28e5bd608ddf84dc40160596b84c3048e60e..18a7bc928be2bd8e62770a4da136b38627a8bd04 100644

--- a/media/renderers/video_renderer_impl.cc

+++ b/media/renderers/video_renderer_impl.cc

@@ -697,6 +697,7 @@ bool VideoRendererImpl::HaveReachedBufferingCap() {

void VideoRendererImpl::StartSink() {

DCHECK(task_runner_->BelongsToCurrentThread());

+ CHECK_GT(algorithm_->frames_queued(), 0u);

sink_->Start(this);

sink_started_ = true;

was_background_rendering_ = false;

« no previous file with comments | « no previous file | no next file » | no next file with comments »