Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 1145433002: Revert of Preventing the default action on 'mousemove' listener shouldn't prevent selection (Closed)

Created:
5 years, 7 months ago by Rick Byers
Modified:
5 years, 7 months ago
CC:
blink-reviews, blink-reviews-events_chromium.org, dglazkov+blink, eae+blinkwatch
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Preventing the default action on 'mousemove' listener shouldn't prevent selection (patchset #6 id:100001 of https://codereview.chromium.org/1013303003/) Reason for revert: Revert because there are applications (like Google maps - http://crbug.com/485892) which are relying on disabling text selection / drag and drop but are forced to avoid cancelling mousedown (due to http://crbug.com/269917). Original issue's description: > Preventing the default action on 'mousemove' listener shouldn't prevent selection > > As per the spec, mousemove has no default action: > http://www.w3.org/TR/DOM-Level-3-Events/#event-type-mousemove. > Hence preventing the default action on mousemove should not > prevent selection/drag from happening. Made changes to > allow drag operation irrespective of mousemove event > cancellation similar to behavior of other browsers. > > BUG=346473 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192855 TBR=leviw@chromium.org,ojan@chromium.org,rob.buis@samsung.com,ramya.v@samsung.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=346473 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195334

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -50 lines) Patch
D LayoutTests/fast/events/drag-on-mouse-move-cancelled.html View 1 chunk +0 lines, -35 lines 0 comments Download
D LayoutTests/fast/events/drag-on-mouse-move-cancelled-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
M Source/core/page/EventHandler.cpp View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Rick Byers
Created Revert of Preventing the default action on 'mousemove' listener shouldn't prevent selection
5 years, 7 months ago (2015-05-14 01:57:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145433002/1
5 years, 7 months ago (2015-05-14 01:57:42 UTC) #2
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 01:58:41 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195334

Powered by Google App Engine
This is Rietveld 408576698