Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 1145313002: Make Rietveld RPC work with service accounts for public instances. (Closed)

Created:
5 years, 7 months ago by tandrii(chromium)
Modified:
5 years, 6 months ago
Reviewers:
pgervais, hinoka
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Make Rietveld RPC work with service accounts for public instances. R=pgervais@chromium.org, hinoka@chromium.org BUG=489569 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=295723

Patch Set 1 #

Patch Set 2 : TODO #

Patch Set 3 : follow_redirects=False not required! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M rietveld.py View 1 2 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
tandrii(chromium)
Philippe, PTAL fyi Ryan
5 years, 7 months ago (2015-05-20 20:57:13 UTC) #2
pgervais
On 2015/05/20 20:57:13, tandrii(chromium) wrote: > Philippe, PTAL > > fyi Ryan lgtm
5 years, 7 months ago (2015-05-20 22:42:16 UTC) #3
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
5 years, 6 months ago (2015-06-17 15:41:03 UTC) #7
tandrii(chromium)
5 years, 6 months ago (2015-06-17 15:53:28 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 295723 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698