rietveld.py - Issue 1145313002: Make Rietveld RPC work with service accounts for public instances.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: rietveld.py

Issue 1145313002: Make Rietveld RPC work with service accounts for public instances. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: follow_redirects=False not required! Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: rietveld.py

diff --git a/rietveld.py b/rietveld.py

index 0114cfe0ccee6bf9922c03f9c8575191484ef06b..eddf77eef50a7e85b2e38d7783e30f18b7798e25 100644

--- a/rietveld.py

+++ b/rietveld.py

@@ -564,7 +564,9 @@ class JwtOAuth2Rietveld(Rietveld):

private_key_password = 'notasecret'

self.url = url.rstrip('/')

- bot_url = self.url + '/bots'

+ bot_url = self.url

+ if self.url.endswith('googleplex.com'):

+ bot_url = self.url + '/bots'

with open(client_private_key_file, 'rb') as f:

client_private_key = f.read()

« no previous file with comments | « no previous file | no next file » | no next file with comments »