Issue 1145263006: Add RenderClip and use it in FixedHeightScrollable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1145263006: Add RenderClip and use it in FixedHeightScrollable (Closed)

Created:
5 years, 6 months ago by abarth-chromium

Modified:
5 years, 6 months ago

Reviewers:
Hixie, eseidel

CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Add RenderClip and use it in FixedHeightScrollable In the future, we might want to extend this class to clip to a configurable rect in addition to clipping to its bounds. R=eseidel@chromium.org, ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/1f3a439b315120f63d945bf37a930743f15e318d

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -8 lines)			Patch
M	sky/sdk/lib/framework/components2/fixed_height_scrollable.dart	View	1 chunk	+5 lines, -8 lines	0 comments	Download
M	sky/sdk/lib/framework/fn2.dart	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	sky/sdk/lib/framework/rendering/box.dart	View	1 chunk	+13 lines, -0 lines	0 comments	Download

Total messages: 6 (2 generated)

abarth-chromium

Committed patchset #1 (id:1) manually as 1f3a439b315120f63d945bf37a930743f15e318d (presubmit successful).

5 years, 6 months ago (2015-06-04 18:14:34 UTC) #4

Message was sent while issue was closed.

lgtm