Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: sky/sdk/lib/framework/components2/fixed_height_scrollable.dart

Issue 1145263006: Add RenderClip and use it in FixedHeightScrollable (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/sdk/lib/framework/fn2.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/sdk/lib/framework/components2/fixed_height_scrollable.dart
diff --git a/sky/sdk/lib/framework/components2/fixed_height_scrollable.dart b/sky/sdk/lib/framework/components2/fixed_height_scrollable.dart
index 3a47f86bd044c6c82b6a7e401dd8187aac85f104..2cf747d2c3ed51a02a05913f6defec556b8a6e65 100644
--- a/sky/sdk/lib/framework/components2/fixed_height_scrollable.dart
+++ b/sky/sdk/lib/framework/components2/fixed_height_scrollable.dart
@@ -70,14 +70,11 @@ abstract class FixedHeightScrollable extends Scrollable {
}
}
- // TODO(abarth): Add a clip.
- return new BlockContainer(
- children: [
- new Transform(
- transform: transform,
- child: new BlockContainer(children: buildItems(itemNumber, drawCount))
- )
- ]
+ return new Clip(
+ child: new Transform(
+ transform: transform,
+ child: new BlockContainer(children: buildItems(itemNumber, drawCount))
+ )
);
}
« no previous file with comments | « no previous file | sky/sdk/lib/framework/fn2.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698