Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1145233002: Revert of Change WebContents::last_active_time_ to Time instead of Timeticks. (Closed)

Created:
5 years, 7 months ago by gab
Modified:
5 years, 7 months ago
CC:
chromium-reviews, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, yurys, darin-cc_chromium.org, pfeldman, oshima+watch_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, gab, chrisha
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Change WebContents::last_active_time_ to Time instead of Timeticks. (patchset #1 id:140001 of https://codereview.chromium.org/1140083004/) Reason for revert: Reverting for georgesak@ (his committer access hasn't propagated yet it looks like). After discussion with sky@, decided to keep TimeTicks. Original issue's description: > Change WebContents::last_active_time_ to Time instead of Timeticks. > > For context, last_active_time_ is going to be used by session restore to order the loading of background tabs using MRU. In order for this to be robust, last_active_time_ must be saved and restore between sessions. Timeticks cannot be reliably restored as it's dependent on the current OS session. MRU code for session restore is being implemented in https://codereview.chromium.org/1131373003 > > Notes: > - In dev tools, replaced "activity" with "active" for consistency > - In OomPriorityManagerTest.Comparator, initialized last_active_time for all tabs, as this is necessary with Time (a default TimeTicks can go back in time, not the case with Time). > > BUG=472772 > > Committed: https://crrev.com/041ef9c96d9a5b6f206a24385b0e6e4b3dbf9f20 > Cr-Commit-Position: refs/heads/master@{#330029} TBR=jamescook@chromium.org,jam@chromium.org,georgesak@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=472772 Committed: https://crrev.com/0dccfef67664a8304772e46696be7f15ee177419 Cr-Commit-Position: refs/heads/master@{#330778}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -25 lines) Patch
M chrome/browser/android/dev_tools_discovery_provider_android.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/memory/oom_priority_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/memory/oom_priority_manager_unittest.cc View 5 chunks +1 line, -6 lines 0 comments Download
M components/devtools_discovery/basic_target_descriptor.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/devtools_discovery/basic_target_descriptor.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/devtools_discovery/devtools_target_descriptor.h View 1 chunk +1 line, -1 line 0 comments Download
M components/devtools_http_handler/devtools_http_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/web_contents/web_contents_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/web_contents.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
gab
Created Revert of Change WebContents::last_active_time_ to Time instead of Timeticks.
5 years, 7 months ago (2015-05-20 18:41:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145233002/1
5 years, 7 months ago (2015-05-20 18:42:23 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-20 18:43:53 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 18:44:52 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0dccfef67664a8304772e46696be7f15ee177419
Cr-Commit-Position: refs/heads/master@{#330778}

Powered by Google App Engine
This is Rietveld 408576698