Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Side by Side Diff: components/devtools_discovery/basic_target_descriptor.h

Issue 1145233002: Revert of Change WebContents::last_active_time_ to Time instead of Timeticks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_DEVTOOLS_DISCOVERY_BASIC_TARGET_DESCRIPTOR_H_ 5 #ifndef COMPONENTS_DEVTOOLS_DISCOVERY_BASIC_TARGET_DESCRIPTOR_H_
6 #define COMPONENTS_DEVTOOLS_DISCOVERY_BASIC_TARGET_DESCRIPTOR_H_ 6 #define COMPONENTS_DEVTOOLS_DISCOVERY_BASIC_TARGET_DESCRIPTOR_H_
7 7
8 #include "components/devtools_discovery/devtools_target_descriptor.h" 8 #include "components/devtools_discovery/devtools_target_descriptor.h"
9 9
10 namespace devtools_discovery { 10 namespace devtools_discovery {
(...skipping 10 matching lines...) Expand all
21 static const char kTypeOther[]; 21 static const char kTypeOther[];
22 22
23 // DevToolsTargetDescriptor implementation. 23 // DevToolsTargetDescriptor implementation.
24 std::string GetId() const override; 24 std::string GetId() const override;
25 std::string GetParentId() const override; 25 std::string GetParentId() const override;
26 std::string GetType() const override; 26 std::string GetType() const override;
27 std::string GetTitle() const override; 27 std::string GetTitle() const override;
28 std::string GetDescription() const override; 28 std::string GetDescription() const override;
29 GURL GetURL() const override; 29 GURL GetURL() const override;
30 GURL GetFaviconURL() const override; 30 GURL GetFaviconURL() const override;
31 base::Time GetLastActiveTime() const override; 31 base::TimeTicks GetLastActivityTime() const override;
32 bool IsAttached() const override; 32 bool IsAttached() const override;
33 scoped_refptr<content::DevToolsAgentHost> GetAgentHost() const override; 33 scoped_refptr<content::DevToolsAgentHost> GetAgentHost() const override;
34 bool Activate() const override; 34 bool Activate() const override;
35 bool Close() const override; 35 bool Close() const override;
36 36
37 protected: 37 protected:
38 void set_parent_id(const std::string& parent_id) { parent_id_ = parent_id; } 38 void set_parent_id(const std::string& parent_id) { parent_id_ = parent_id; }
39 void set_type(const std::string& type) { type_ = type; } 39 void set_type(const std::string& type) { type_ = type; }
40 void set_title(const std::string& title) { title_ = title; } 40 void set_title(const std::string& title) { title_ = title; }
41 void set_description(const std::string& desc) { description_ = desc; } 41 void set_description(const std::string& desc) { description_ = desc; }
42 void set_url(const GURL& url) { url_ = url; } 42 void set_url(const GURL& url) { url_ = url; }
43 void set_favicon_url(const GURL& url) { favicon_url_ = url; } 43 void set_favicon_url(const GURL& url) { favicon_url_ = url; }
44 44
45 private: 45 private:
46 scoped_refptr<content::DevToolsAgentHost> agent_host_; 46 scoped_refptr<content::DevToolsAgentHost> agent_host_;
47 std::string parent_id_; 47 std::string parent_id_;
48 std::string type_; 48 std::string type_;
49 std::string title_; 49 std::string title_;
50 std::string description_; 50 std::string description_;
51 GURL url_; 51 GURL url_;
52 GURL favicon_url_; 52 GURL favicon_url_;
53 base::Time last_active_time_; 53 base::TimeTicks last_activity_time_;
54 }; 54 };
55 55
56 } // namespace devtools_discovery 56 } // namespace devtools_discovery
57 57
58 #endif // COMPONENTS_DEVTOOLS_DISCOVERY_BASIC_TARGET_DESCRIPTOR_H_ 58 #endif // COMPONENTS_DEVTOOLS_DISCOVERY_BASIC_TARGET_DESCRIPTOR_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698