Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Issue 1145143002: [turbofan] Pass deoptimization mode to type feedback specializer. (Closed)

Created:
5 years, 7 months ago by Benedikt Meurer
Modified:
5 years, 7 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Pass deoptimization mode to type feedback specializer. R=jarin@chromium.org Committed: https://crrev.com/4a1ab1cac471f2fa5741723f174bb336e77eeda0 Cr-Commit-Position: refs/heads/master@{#28524}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+229 lines, -160 lines) Patch
M src/compiler/js-type-feedback.h View 3 chunks +7 lines, -1 line 0 comments Download
M src/compiler/js-type-feedback.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/pipeline.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M test/unittests/compiler/js-type-feedback-unittest.cc View 5 chunks +215 lines, -153 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 7 months ago (2015-05-20 13:23:59 UTC) #1
Benedikt Meurer
Hey Jaro, FLAG_turbo_deoptimization -= N. Similar to the change earlier. Please take a look. Thanks, ...
5 years, 7 months ago (2015-05-20 13:24:40 UTC) #2
Jarin
lgtm
5 years, 7 months ago (2015-05-20 13:37:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145143002/1
5 years, 7 months ago (2015-05-20 16:28:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-20 17:01:37 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 17:01:54 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4a1ab1cac471f2fa5741723f174bb336e77eeda0
Cr-Commit-Position: refs/heads/master@{#28524}

Powered by Google App Engine
This is Rietveld 408576698