Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: src/compiler/pipeline.cc

Issue 1145143002: [turbofan] Pass deoptimization mode to type feedback specializer. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/js-type-feedback.cc ('k') | test/unittests/compiler/js-type-feedback-unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/pipeline.cc
diff --git a/src/compiler/pipeline.cc b/src/compiler/pipeline.cc
index 4118e1dfad77d0466f40c74a84a2f06f5e42fcfb..e74c9fba71af7778a4f04ae5ccd220a5aec41c86 100644
--- a/src/compiler/pipeline.cc
+++ b/src/compiler/pipeline.cc
@@ -546,7 +546,10 @@ struct JSTypeFeedbackPhase {
// specializing to the global object here.
JSTypeFeedbackSpecializer specializer(
&graph_reducer, data->jsgraph(), data->js_type_feedback(), &oracle,
- global_object, data->info()->dependencies());
+ global_object, data->info()->is_deoptimization_enabled()
+ ? JSTypeFeedbackSpecializer::kDeoptimizationEnabled
+ : JSTypeFeedbackSpecializer::kDeoptimizationDisabled,
+ data->info()->dependencies());
AddReducer(data, &graph_reducer, &specializer);
graph_reducer.ReduceGraph();
}
@@ -1048,9 +1051,7 @@ Handle<Code> Pipeline::GenerateCode() {
RunPrintAndVerify("OSR deconstruction");
}
- // TODO(turbofan): Type feedback currently requires deoptimization.
- if (info()->is_deoptimization_enabled() &&
- info()->is_type_feedback_enabled()) {
+ if (info()->is_type_feedback_enabled()) {
Run<JSTypeFeedbackPhase>();
RunPrintAndVerify("JSType feedback");
}
« no previous file with comments | « src/compiler/js-type-feedback.cc ('k') | test/unittests/compiler/js-type-feedback-unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698