Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 1145113003: Revert of Set lower allocation limit in idle notification only if no GC happend recently. (Closed)

Created:
5 years, 7 months ago by Michael Achenbach
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Set lower allocation limit in idle notification only if no GC happend recently. (patchset #2 id:20001 of https://codereview.chromium.org/1143113002/) Reason for revert: [Sheriff] MSAN not happy: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/2352 Original issue's description: > Set lower allocation limit in idle notification only if no GC happend recently. > > BUG=475674 > LOG=n > > Committed: https://crrev.com/35e3489e8f70c7ad5973324ad3cfa4ab27059ab4 > Cr-Commit-Position: refs/heads/master@{#28506} TBR=ulan@chromium.org,hpayer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=475674 Committed: https://crrev.com/64b1b1d13047ac8dc37b108cb9e276da0d8a0a8e Cr-Commit-Position: refs/heads/master@{#28511}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -11 lines) Patch
M src/heap/heap.h View 1 chunk +3 lines, -6 lines 0 comments Download
M src/heap/heap.cc View 3 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of Set lower allocation limit in idle notification only if no GC happend ...
5 years, 7 months ago (2015-05-20 12:48:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145113003/1
5 years, 7 months ago (2015-05-20 12:48:54 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-20 12:49:19 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 12:49:32 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/64b1b1d13047ac8dc37b108cb9e276da0d8a0a8e
Cr-Commit-Position: refs/heads/master@{#28511}

Powered by Google App Engine
This is Rietveld 408576698