Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 1143113002: Set lower allocation limit in idle notification only if no GC happend recently. (Closed)

Created:
5 years, 7 months ago by Hannes Payer (out of office)
Modified:
5 years, 7 months ago
Reviewers:
ulan
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Set lower allocation limit in idle notification only if no GC happend recently. BUG=475674 LOG=n Committed: https://crrev.com/35e3489e8f70c7ad5973324ad3cfa4ab27059ab4 Cr-Commit-Position: refs/heads/master@{#28506}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M src/heap/heap.h View 1 1 chunk +6 lines, -3 lines 0 comments Download
M src/heap/heap.cc View 3 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Hannes Payer (out of office)
5 years, 7 months ago (2015-05-20 07:46:14 UTC) #2
ulan
lgtm. Let's land this to fix perf regression. Later we can generalize this to use ...
5 years, 7 months ago (2015-05-20 10:37:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143113002/20001
5 years, 7 months ago (2015-05-20 10:58:32 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-20 10:59:49 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/35e3489e8f70c7ad5973324ad3cfa4ab27059ab4 Cr-Commit-Position: refs/heads/master@{#28506}
5 years, 7 months ago (2015-05-20 11:00:01 UTC) #7
Michael Achenbach
5 years, 7 months ago (2015-05-20 12:48:39 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1145113003/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] MSAN not happy:
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20s....

Powered by Google App Engine
This is Rietveld 408576698