Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1145113002: Build javascript unit tests with gn. (Closed)

Created:
5 years, 7 months ago by Peter Lundblad
Modified:
5 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Build javascript unit tests with gn. This extends the js2gtest template and uses it for the gtestjs unit tests. BUG=None Committed: https://crrev.com/fa69ff87b07d19f36468412313fab80f4e3b389d Cr-Commit-Position: refs/heads/master@{#330907}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -26 lines) Patch
M chrome/chrome_tests_unit.gypi View 8 chunks +37 lines, -21 lines 0 comments Download
M chrome/test/BUILD.gn View 7 chunks +45 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Peter Lundblad
5 years, 7 months ago (2015-05-20 13:09:20 UTC) #2
brettw
lgtm
5 years, 7 months ago (2015-05-20 18:28:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145113002/1
5 years, 7 months ago (2015-05-21 06:54:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-21 07:01:24 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-21 07:02:17 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fa69ff87b07d19f36468412313fab80f4e3b389d
Cr-Commit-Position: refs/heads/master@{#330907}

Powered by Google App Engine
This is Rietveld 408576698