Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 1145073003: Subsituting pattern ScopedVector push_back.(ptr.release()) with push_back(ptr.Pass()) in extensions… (Closed)

Created:
5 years, 7 months ago by vaibhav1.a
Modified:
5 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Subsituting pattern ScopedVector push_back.(ptr.release()) with push_back(ptr.Pass()) in extensions/renderer BUG=457697 Committed: https://crrev.com/d73326857b0df7891db6929403da1372a61f005a Cr-Commit-Position: refs/heads/master@{#331537}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/renderer/script_injection_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/renderer/user_script_set.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
vaibhav1.a
Uploaded the patch please review.
5 years, 7 months ago (2015-05-22 07:10:23 UTC) #2
Reilly Grant (use Gerrit)
lgtm
5 years, 7 months ago (2015-05-22 20:02:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145073003/1
5 years, 7 months ago (2015-05-27 04:47:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-27 05:45:55 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-27 05:46:40 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d73326857b0df7891db6929403da1372a61f005a
Cr-Commit-Position: refs/heads/master@{#331537}

Powered by Google App Engine
This is Rietveld 408576698