extensions/renderer/script_injection_manager.cc - Issue 1145073003: Subsituting pattern ScopedVector push_back.(ptr.release()) with push_back(ptr.Pass()) in extensions…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/script_injection_manager.cc

Issue 1145073003: Subsituting pattern ScopedVector push_back.(ptr.release()) with push_back(ptr.Pass()) in extensions… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/renderer/script_injection_manager.cc

diff --git a/extensions/renderer/script_injection_manager.cc b/extensions/renderer/script_injection_manager.cc

index d5fe072041d1b522b030948b517030ab2edd6ed4..f758b95015afa057c521051497c8fe5e1144a8fd 100644

--- a/extensions/renderer/script_injection_manager.cc

+++ b/extensions/renderer/script_injection_manager.cc

@@ -379,10 +379,10 @@ void ScriptInjectionManager::TryToInject(

scripts_run_info,

this)) {

case ScriptInjection::INJECTION_WAITING:

- pending_injections_.push_back(injection.release());

+ pending_injections_.push_back(injection.Pass());

break;

case ScriptInjection::INJECTION_BLOCKED:

- running_injections_.push_back(injection.release());

+ running_injections_.push_back(injection.Pass());

break;

case ScriptInjection::INJECTION_FINISHED:

break;

« no previous file with comments | « AUTHORS ('k') | extensions/renderer/user_script_set.cc » ('j') | no next file with comments »