Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 1145043003: Roll Clang 233105-2:238013-1 (Closed)

Created:
5 years, 7 months ago by hans
Modified:
5 years, 7 months ago
Reviewers:
brettw, Nico
CC:
chromium-reviews, eugenis+clang_chromium.org, glider+clang_chromium.org, dmikurube+clang_chromium.org, ukai+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll Clang 233105-2:238013-1 Note to sheriffs: we're expecting a ~400 kB size regression due to a bug fix that causes more loop unrolling in this Clang version. BUG=483026 NOPRESUBMIT=true TBR=brettw Committed: https://crrev.com/55cf2e7a89eee71a345b3d1a12cec16a85a9db50 Cr-Commit-Position: refs/heads/master@{#331395}

Patch Set 1 #

Patch Set 2 : Try 238013 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -38 lines) Patch
M build/common.gypi View 1 chunk +8 lines, -0 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 chunk +7 lines, -0 lines 0 comments Download
M tools/clang/blink_gc_plugin/JsonWriter.h View 3 chunks +3 lines, -15 lines 0 comments Download
M tools/clang/scripts/update.sh View 1 4 chunks +35 lines, -23 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
hans
This is like https://codereview.chromium.org/1144933003, but also includes r237984 which fixes the blink miscompile from the ...
5 years, 7 months ago (2015-05-22 19:58:23 UTC) #2
Nico
rs-lgtm
5 years, 7 months ago (2015-05-22 20:01:18 UTC) #3
hans
:-( http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_dbg_ng/builds/270/steps/compile%20%28with%20patch%29/logs/stdio Apparently this one got fixed in 238011
5 years, 7 months ago (2015-05-22 20:31:28 UTC) #4
hans
I think 238013 looks good. Only one red tryjob: linux_chromium_chromeos_asan_rel_ng: Looks like a timeout. It ...
5 years, 7 months ago (2015-05-26 16:25:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145043003/20001
5 years, 7 months ago (2015-05-26 16:26:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145043003/20001
5 years, 7 months ago (2015-05-26 16:29:48 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-26 18:14:03 UTC) #12
commit-bot: I haz the power
5 years, 7 months ago (2015-05-26 18:14:54 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/55cf2e7a89eee71a345b3d1a12cec16a85a9db50
Cr-Commit-Position: refs/heads/master@{#331395}

Powered by Google App Engine
This is Rietveld 408576698