Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 1144933003: Roll Clang 233105-2:237739-1 (Closed)

Created:
5 years, 7 months ago by hans
Modified:
5 years, 7 months ago
Reviewers:
Nico, brettw
CC:
chromium-reviews, eugenis+clang_chromium.org, glider+clang_chromium.org, dmikurube+clang_chromium.org, ukai+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll Clang 233105-2:237739-1 Note to sheriffs: we're expecting a ~400 kB size regression due to a bug fix that causes more loop unrolling in this Clang version. BUG=483026 NOPRESUBMIT=true TBR=brettw Committed: https://crrev.com/0e80c361a00645fbcdc8503225ccf12ebd1ef597 Cr-Commit-Position: refs/heads/master@{#330764}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -38 lines) Patch
M build/common.gypi View 1 chunk +8 lines, -0 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 chunk +7 lines, -0 lines 0 comments Download
M tools/clang/blink_gc_plugin/JsonWriter.h View 3 chunks +3 lines, -15 lines 0 comments Download
M tools/clang/scripts/update.sh View 4 chunks +35 lines, -23 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
hans
thakis: Please take a look. brettw: TBR; the gn change was already reviewed in https://codereview.chromium.org/1135023004/
5 years, 7 months ago (2015-05-20 15:44:56 UTC) #3
Nico
On 2015/05/20 15:44:56, hans wrote: > thakis: Please take a look. > > brettw: TBR; ...
5 years, 7 months ago (2015-05-20 15:53:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144933003/1
5 years, 7 months ago (2015-05-20 15:55:08 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-20 17:46:54 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 17:47:56 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0e80c361a00645fbcdc8503225ccf12ebd1ef597
Cr-Commit-Position: refs/heads/master@{#330764}

Powered by Google App Engine
This is Rietveld 408576698