chrome/settings: Implement the 'get themes' button.

chrome/settings: Implement the 'get themes' button.

BUG=none
R=jlklein@chromium.org

Committed: https://crrev.com/c9fc48112618de5f0caca5b773a920a984fbf138
Cr-Commit-Position: refs/heads/master@{#333064}

[James Hawkins, 2015-06-05 01:29:12]

jhawkins@chromium.org changed reviewers:
+ khorimoto@chromium.org

[Jeremy Klein, 2015-06-05 04:39:25]

jlklein@chromium.org changed reviewers:
+ jlklein@chromium.org

[Jeremy Klein, 2015-06-05 04:39:25]

https://codereview.chromium.org/1144963006/diff/1/chrome/browser/ui/webui/set...
File chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
(right):

https://codereview.chromium.org/1144963006/diff/1/chrome/browser/ui/webui/set...
chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc:96:
"themesGalleryUrl", IDS_THEMES_GALLERY_URL);
Should we pull this theme into our own grd? Not sure we should rely on
chrome/app/resources/locale_settings.grd

[James Hawkins, 2015-06-05 15:28:23]

https://codereview.chromium.org/1144963006/diff/1/chrome/browser/ui/webui/set...
File chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
(right):

https://codereview.chromium.org/1144963006/diff/1/chrome/browser/ui/webui/set...
chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc:96:
"themesGalleryUrl", IDS_THEMES_GALLERY_URL);
On 2015/06/05 04:39:25, Jeremy Klein wrote:
> Should we pull this theme into our own grd? Not sure we should rely on
> chrome/app/resources/locale_settings.grd

What is your concern with that dependency?

locale_settings.grd is the place for strings that depend on the current locale. 
It gets worked over by grit into local_settings_[all locales].grd.  I suppose
technically we could create our own .grd for this purpose (including the gn-foo
to generate all of the locale-specific files), but then we'd have two copies of
the same URL (the other being for options, which I'm not a fan of.  Having all
locale-specific strings in one file seems to be the convention, and I prefer to
stick with that unless it becomes an issue.

[Jeremy Klein, 2015-06-05 16:23:27]

lgtm

https://codereview.chromium.org/1144963006/diff/1/chrome/browser/ui/webui/set...
File chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
(right):

https://codereview.chromium.org/1144963006/diff/1/chrome/browser/ui/webui/set...
chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc:96:
"themesGalleryUrl", IDS_THEMES_GALLERY_URL);
On 2015/06/05 15:28:23, James Hawkins wrote:
> On 2015/06/05 04:39:25, Jeremy Klein wrote:
> > Should we pull this theme into our own grd? Not sure we should rely on
> > chrome/app/resources/locale_settings.grd
> 
> What is your concern with that dependency?
> 
> locale_settings.grd is the place for strings that depend on the current
locale. 
> It gets worked over by grit into local_settings_[all locales].grd.  I suppose
> technically we could create our own .grd for this purpose (including the
gn-foo
> to generate all of the locale-specific files), but then we'd have two copies
of
> the same URL (the other being for options, which I'm not a fan of.  Having all
> locale-specific strings in one file seems to be the convention, and I prefer
to
> stick with that unless it becomes an issue.

SGTM, I just wasn't sure how that file was used.

[James Hawkins, 2015-06-05 16:30:05]

Committed patchset #1 (id:1) manually as
c9fc48112618de5f0caca5b773a920a984fbf138 (presubmit successful).

[commit-bot: I haz the power, 2015-06-05 16:30:11]

Patchset 1 (id:??) landed as
https://crrev.com/c9fc48112618de5f0caca5b773a920a984fbf138
Cr-Commit-Position: refs/heads/master@{#333064}