chrome/settings: Implement the 'get themes' button.

chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.h"
 
 #include "chrome/grit/generated_resources.h"
+#include "chrome/grit/locale_settings.h"
 #include "content/public/browser/web_ui_data_source.h"
 
 namespace {
 
 // Note that md_settings.html contains a <script> tag which imports a script of
 // the following name. These names must be kept in sync.
 const char kLocalizedStringsFile[] = "strings.js";
 
 void AddA11yStrings(content::WebUIDataSource* html_source) {
   html_source->AddLocalizedString(
@@ skipping 66 matching lines @@
   html_source->AddLocalizedString(
       "appearanceShowHomeButtonLabel",
       IDS_SETTINGS_APPEARANCE_SHOW_HOME_BUTTON_LABEL);
   html_source->AddLocalizedString(
       "appearanceShowBookmarksBarLabel",
       IDS_SETTINGS_APPEARANCE_SHOW_BOOKMARKS_BAR_LABEL);
   html_source->AddLocalizedString(
       "homePageNtp", IDS_SETTINGS_HOME_PAGE_NTP);
   html_source->AddLocalizedString(
       "changeHomePage", IDS_SETTINGS_CHANGE_HOME_PAGE);
+  html_source->AddLocalizedString(
+      "themesGalleryUrl", IDS_THEMES_GALLERY_URL);

[Jeremy Klein, 2015/06/05 04:39:25]

Should we pull this theme into our own grd? Not sure we should rely on
chrome/app/resources/locale_settings.grd

[James Hawkins, 2015/06/05 15:28:23]

What is your concern with that dependency?

locale_settings.grd is the place for strings that depend on the current locale. 
It gets worked over by grit into local_settings_[all locales].grd.  I suppose
technically we could create our own .grd for this purpose (including the gn-foo
to generate all of the locale-specific files), but then we'd have two copies of
the same URL (the other being for options, which I'm not a fan of.  Having all
locale-specific strings in one file seems to be the convention, and I prefer to
stick with that unless it becomes an issue.

[Jeremy Klein, 2015/06/05 16:23:27]

SGTM, I just wasn't sure how that file was used.

 }
 
 void AddCommonStrings(content::WebUIDataSource* html_source) {
   html_source->AddLocalizedString("addLabel", IDS_ADD);
 }
 
 void AddDownloadsStrings(content::WebUIDataSource* html_source) {
   html_source->AddLocalizedString(
       "downloadsPageTitle", IDS_SETTINGS_DOWNLOADS_PAGE_TITLE);
   html_source->AddLocalizedString(
@@ skipping 98 matching lines @@
 #if defined(OS_CHROMEOS)
   AddInternetStrings(html_source);
 #endif
   AddSearchStrings(html_source);
   AddSearchEnginesStrings(html_source);
   AddUsersStrings(html_source);
   html_source->SetJsonPath(kLocalizedStringsFile);
 }
 
 }  // namespace settings