Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 1144933004: Revert of Various ASan exemptions to allow Oilpan pre-sweep poisoning of unmarkeds. (Closed)

Created:
5 years, 7 months ago by sof
Modified:
5 years, 7 months ago
CC:
blink-reviews, Mads Ager (chromium), oilpan-reviews, blink-reviews-wtf_chromium.org, aandrey+blink_chromium.org, kouhei+heap_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Various ASan exemptions to allow Oilpan pre-sweep poisoning of unmarkeds. (patchset #6 id:100001 of https://codereview.chromium.org/1120943002/) Reason for revert: Broke non-Oilpan ASAN compilation, http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20ASAN/builds/18615 Original issue's description: > Various ASan exemptions to allow Oilpan pre-sweep poisoning of unmarkeds. > > Heap objects must not access other dead objects while finalizing. > To help catch out those that do, the Oilpan GC can now poison > unmarked, to-be-swept objects. To be able to make use of that > with ASan enabled, a couple of benign accesses that run afoul > of that strict check are still needed & must be allowed to > make this feasible. > > Here provided together -- the ones related to Timer stopping & > removal from the timer heap aren't something we'd typically want > to impose one the Blink codebase in general, but beside the > goal of better ASan coverage, the timer heap will soon be removed > and the need for these should fall away. > > R=haraken,tkent,yutak > BUG=420515 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195609 TBR=haraken@chromium.org,yutak@chromium.org,tkent@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=420515 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195611

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -34 lines) Patch
M Source/platform/ThreadTimers.cpp View 3 chunks +1 line, -2 lines 0 comments Download
M Source/platform/Timer.h View 5 chunks +0 lines, -5 lines 0 comments Download
M Source/platform/Timer.cpp View 5 chunks +0 lines, -5 lines 0 comments Download
M Source/platform/heap/AddressSanitizer.h View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/platform/heap/Handle.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/platform/heap/ThreadState.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M Source/wtf/LinkedHashSet.h View 2 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sof
Created Revert of Various ASan exemptions to allow Oilpan pre-sweep poisoning of unmarkeds.
5 years, 7 months ago (2015-05-20 11:05:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144933004/1
5 years, 7 months ago (2015-05-20 11:05:50 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=195611
5 years, 7 months ago (2015-05-20 11:06:22 UTC) #3
tkent
5 years, 7 months ago (2015-05-20 23:30:38 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698