Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1392)

Side by Side Diff: Source/platform/Timer.h

Issue 1144933004: Revert of Various ASan exemptions to allow Oilpan pre-sweep poisoning of unmarkeds. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/platform/ThreadTimers.cpp ('k') | Source/platform/Timer.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006 Apple Computer, Inc. All rights reserved. 2 * Copyright (C) 2006 Apple Computer, Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
11 * documentation and/or other materials provided with the distribution. 11 * documentation and/or other materials provided with the distribution.
12 * 12 *
13 * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY 13 * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY
14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR 16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR
17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, 17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, 18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR 19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY 20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24 */ 24 */
25 25
26 #ifndef Timer_h 26 #ifndef Timer_h
27 #define Timer_h 27 #define Timer_h
28 28
29 #include "platform/PlatformExport.h" 29 #include "platform/PlatformExport.h"
30 #include "platform/heap/AddressSanitizer.h"
31 #include "platform/heap/Handle.h" 30 #include "platform/heap/Handle.h"
32 #include "public/platform/WebTraceLocation.h" 31 #include "public/platform/WebTraceLocation.h"
33 #include "wtf/Noncopyable.h" 32 #include "wtf/Noncopyable.h"
34 #include "wtf/Threading.h" 33 #include "wtf/Threading.h"
35 #include "wtf/Vector.h" 34 #include "wtf/Vector.h"
36 35
37 namespace blink { 36 namespace blink {
38 37
39 // Time intervals are all in seconds. 38 // Time intervals are all in seconds.
40 39
(...skipping 25 matching lines...) Expand all
66 void augmentRepeatInterval(double delta) { 65 void augmentRepeatInterval(double delta) {
67 setNextFireTime(m_nextFireTime + delta); 66 setNextFireTime(m_nextFireTime + delta);
68 m_repeatInterval += delta; 67 m_repeatInterval += delta;
69 } 68 }
70 69
71 void didChangeAlignmentInterval(); 70 void didChangeAlignmentInterval();
72 71
73 private: 72 private:
74 virtual void fired() = 0; 73 virtual void fired() = 0;
75 74
76 NO_LAZY_SWEEP_SANITIZE_ADDRESS
77 virtual double alignedFireTime(double fireTime) const { return fireTime; } 75 virtual double alignedFireTime(double fireTime) const { return fireTime; }
78 76
79 void checkConsistency() const; 77 void checkConsistency() const;
80 void checkHeapIndex() const; 78 void checkHeapIndex() const;
81 79
82 void setNextFireTime(double); 80 void setNextFireTime(double);
83 81
84 NO_LAZY_SWEEP_SANITIZE_ADDRESS
85 bool inHeap() const { return m_heapIndex != -1; } 82 bool inHeap() const { return m_heapIndex != -1; }
86 83
87 bool hasValidHeapPosition() const; 84 bool hasValidHeapPosition() const;
88 void updateHeapIfNeeded(double oldTime); 85 void updateHeapIfNeeded(double oldTime);
89 86
90 void heapDecreaseKey(); 87 void heapDecreaseKey();
91 void heapDelete(); 88 void heapDelete();
92 void heapDeleteMin(); 89 void heapDeleteMin();
93 void heapIncreaseKey(); 90 void heapIncreaseKey();
94 void heapInsert(); 91 void heapInsert();
95 void heapPop(); 92 void heapPop();
96 void heapPopMin(); 93 void heapPopMin();
97 94
98 NO_LAZY_SWEEP_SANITIZE_ADDRESS
99 Vector<TimerBase*>& timerHeap() const { ASSERT(m_cachedThreadGlobalTimerHeap ); return *m_cachedThreadGlobalTimerHeap; } 95 Vector<TimerBase*>& timerHeap() const { ASSERT(m_cachedThreadGlobalTimerHeap ); return *m_cachedThreadGlobalTimerHeap; }
100 96
101 double m_nextFireTime; // 0 if inactive 97 double m_nextFireTime; // 0 if inactive
102 double m_unalignedNextFireTime; // m_nextFireTime not considering alignment interval 98 double m_unalignedNextFireTime; // m_nextFireTime not considering alignment interval
103 double m_repeatInterval; // 0 if not repeating 99 double m_repeatInterval; // 0 if not repeating
104 int m_heapIndex; // -1 if not in heap 100 int m_heapIndex; // -1 if not in heap
105 unsigned m_heapInsertionOrder; // Used to keep order among equal-fire-time t imers 101 unsigned m_heapInsertionOrder; // Used to keep order among equal-fire-time t imers
106 Vector<TimerBase*>* m_cachedThreadGlobalTimerHeap; 102 Vector<TimerBase*>* m_cachedThreadGlobalTimerHeap;
107 WebTraceLocation m_location; 103 WebTraceLocation m_location;
108 104
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
151 147
152 private: 148 private:
153 // FIXME: oilpan: TimerBase should be moved to the heap and m_object should be traced. 149 // FIXME: oilpan: TimerBase should be moved to the heap and m_object should be traced.
154 // This raw pointer is safe as long as Timer<X> is held by the X itself (Tha t's the case 150 // This raw pointer is safe as long as Timer<X> is held by the X itself (Tha t's the case
155 // in the current code base). 151 // in the current code base).
156 GC_PLUGIN_IGNORE("363031") 152 GC_PLUGIN_IGNORE("363031")
157 TimerFiredClass* m_object; 153 TimerFiredClass* m_object;
158 TimerFiredFunction m_function; 154 TimerFiredFunction m_function;
159 }; 155 };
160 156
161 NO_LAZY_SWEEP_SANITIZE_ADDRESS
162 inline bool TimerBase::isActive() const 157 inline bool TimerBase::isActive() const
163 { 158 {
164 ASSERT(m_thread == currentThread()); 159 ASSERT(m_thread == currentThread());
165 return m_nextFireTime; 160 return m_nextFireTime;
166 } 161 }
167 162
168 } 163 }
169 164
170 #endif 165 #endif
OLDNEW
« no previous file with comments | « Source/platform/ThreadTimers.cpp ('k') | Source/platform/Timer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698