Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 1144923008: Use ldr for movs out of stack slots (instead of mov reg, [sp/fp]). (Closed)

Created:
5 years, 7 months ago by jvoung (off chromium)
Modified:
5 years, 7 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use ldr for movs out of stack slots (instead of mov reg, [sp/fp]). So far we've been using ldr/str (32-bit) to load/store the whole stack slot, independent of the variable type. Toggle on some tests that didn't have an Om1 variant previously. Didn't toggle everything since there are still some problems with liveness from code being unimplemented. BUG= https://code.google.com/p/nativeclient/issues/detail?id=4076 R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=c207d51ea50154e73891cb306bf00c8eccf7306e

Patch Set 1 #

Patch Set 2 : refactor #

Patch Set 3 : scope better #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -3 lines) Patch
M src/IceInstARM32.cpp View 1 2 1 chunk +12 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/alloc.ll View 1 chunk +4 lines, -0 lines 0 comments Download
M tests_lit/llvm2ice_tests/branch-opt.ll View 4 chunks +32 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
jvoung (off chromium)
5 years, 7 months ago (2015-05-27 17:26:17 UTC) #2
Jim Stichnoth
lgtm, but I don't see any tests? Will you be eventually enabling the TODO tests ...
5 years, 7 months ago (2015-05-27 18:02:31 UTC) #3
jvoung (off chromium)
On 2015/05/27 18:02:31, stichnot wrote: > lgtm, but I don't see any tests? Will you ...
5 years, 7 months ago (2015-05-27 20:12:05 UTC) #4
jvoung (off chromium)
5 years, 7 months ago (2015-05-27 21:34:39 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
c207d51ea50154e73891cb306bf00c8eccf7306e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698