[SP] Delete GraphicsContextAnnotator.

[SP] Delete GraphicsContextAnnotator.

BUG=489825, 486767
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195554

[chrishtr, 2015-05-19 20:18:44]

chrishtr@chromium.org changed reviewers:
+ fmalita@chromium.org, pdr@chromium.org, pfeldman@chromium.org

[chrishtr, 2015-05-19 20:18:59]

See the attached bug for context.

[f(malita), 2015-05-19 20:33:22]

LGTM.

We can also remove GraphicsContextAnnotation.h and the associated GC plumbing,
but I can do that in a separate CL.

[Stephen Chennney, 2015-05-19 20:35:11]

On 2015/05/19 20:18:59, chrishtr wrote:
> See the attached bug for context.

Maybe hold off to see if the change I'm working on fixes the crashes?

The original motivation arose back when the old painting team was trying to
optimize paint, and it was important to know which piece of painting code
generated which piece of bad Skia code. I presume we can get the same
functionality from DisplayItems, but I would rather hold off removing one before
we implement the other. (Although I accept that it's classic Google behavior.)

[chrishtr, 2015-05-19 20:45:35]

On 2015/05/19 at 20:35:11, schenney wrote:
> On 2015/05/19 20:18:59, chrishtr wrote:
> > See the attached bug for context.
> 
> Maybe hold off to see if the change I'm working on fixes the crashes?
> 
> The original motivation arose back when the old painting team was trying to
optimize paint, and it was important to know which piece of painting code
generated which piece of bad Skia code. I presume we can get the same
functionality from DisplayItems, but I would rather hold off removing one before
we implement the other. (Although I accept that it's classic Google behavior.)

I'm pretty sure it won't fix the crashes, because you need a canvas in order to
have the feature work, and the call stack in the bug includes one via
ContentLayerDelegate, which is not under the control of Blink.

I also discussed offline with Paul Irish and he's ok with removing it.

[chrishtr, 2015-05-19 20:45:42]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2015-05-19 20:46:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1144903002/20001

[commit-bot: I haz the power, 2015-05-19 21:39:54]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195554