Mac: Omnibox: Retain the "SelectAll" state after a navigation.

chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

Index: chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm
diff --git a/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm b/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm
index 7d296dd7b43eac1eeaa73540e8d966c7c8375408..a3eac3360421c63489779fcf21b03911be4a1d14 100644
--- a/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm
+++ b/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm
@@ -219,11 +219,15 @@ void OmniboxViewMac::Update() {
     controller()->GetToolbarModel()->set_url_replacement_enabled(true);
     model()->UpdatePermanentText();
 
+    const bool was_select_all = IsSelectAll();
+
     // Restore everything to the baseline look.
     RevertAll();
 
     // TODO(shess): Figure out how this case is used, to make sure
     // we're getting the selection and popup right.

[Peter Kasting, 2015/05/19 07:04:01]

Nit: Remove TODO; copy comment from views code

[tapted, 2015/05/19 11:28:39]

Done.

+    if (was_select_all && model()->has_focus())
+      SelectAll(false /* reversed: ignored on mac */);

[Peter Kasting, 2015/05/19 07:04:00]

Reversed state shouldn't be ignored.  You should save and restore it correctly.

[tapted, 2015/05/19 11:28:39]

Done.

   } else {
     // TODO(shess): This corresponds to _win and _gtk, except those
     // guard it with a test for whether the security level changed.