Mac: Omnibox: Retain the "SelectAll" state after a navigation.

chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h"
 
 #include <Carbon/Carbon.h>  // kVK_Return
 
 #include "base/mac/foundation_util.h"
 #include "base/metrics/histogram.h"
@@ skipping 201 matching lines @@
 void OmniboxViewMac::ResetTabState(WebContents* web_contents) {
   StoreStateToTab(web_contents, nullptr);
 }
 
 void OmniboxViewMac::Update() {
   if (model()->UpdatePermanentText()) {
     // Something visibly changed.  Re-enable URL replacement.
     controller()->GetToolbarModel()->set_url_replacement_enabled(true);
     model()->UpdatePermanentText();
 
+    const bool was_select_all = IsSelectAll();
+
     // Restore everything to the baseline look.
     RevertAll();
 
     // TODO(shess): Figure out how this case is used, to make sure
     // we're getting the selection and popup right.

[Peter Kasting, 2015/05/19 07:04:01]

Nit: Remove TODO; copy comment from views code

[tapted, 2015/05/19 11:28:39]

Done.

+    if (was_select_all && model()->has_focus())
+      SelectAll(false /* reversed: ignored on mac */);

[Peter Kasting, 2015/05/19 07:04:00]

Reversed state shouldn't be ignored.  You should save and restore it correctly.

[tapted, 2015/05/19 11:28:39]

Done.

   } else {
     // TODO(shess): This corresponds to _win and _gtk, except those
     // guard it with a test for whether the security level changed.
     // But AFAICT, that can only change if the text changed, and that
     // code compares the toolbar model security level with the local
     // security level.  Dig in and figure out why this isn't a no-op
     // that should go away.
     EmphasizeURLComponents();
   }
 }
@@ skipping 101 matching lines @@
   }
 
   const NSRange selected_range = GetSelectedRange();
   *start = static_cast<size_t>(selected_range.location);
   *end = static_cast<size_t>(NSMaxRange(selected_range));
 }
 
 void OmniboxViewMac::SelectAll(bool reversed) {
   // TODO(shess): Figure out what |reversed| implies.  The gtk version
   // has it imply inverting the selection front to back, but I don't
   // even know if that makes sense for Mac.

[Peter Kasting, 2015/05/19 07:04:00]

Surely Mac can distinguish between a left-to-right and a right-to-left
selection?

[tapted, 2015/05/19 11:28:39]

Done+tested.

 
   // TODO(shess): Verify that we should be stealing focus at this
   // point.
   SetSelectedRange(NSMakeRange(0, GetTextLength()));
 }
 
 void OmniboxViewMac::RevertAll() {
   OmniboxView::RevertAll();
   [field_ clearUndoChain];
 }
@@ skipping 650 matching lines @@
 
 NSUInteger OmniboxViewMac::GetTextLength() const {
   return [field_ currentEditor] ?  [[[field_ currentEditor] string] length] :
                                    [[field_ stringValue] length];
 }
 
 bool OmniboxViewMac::IsCaretAtEnd() const {
   const NSRange selection = GetSelectedRange();
   return NSMaxRange(selection) == GetTextLength();
 }