Issue 11448030: Allow all value types in evaluate additional context

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11448030: Allow all value types in evaluate additional context (Closed)

Created:
8 years ago by Peter Rybin

Modified:
8 years ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Allow all value types in evaluate additional context Committed: http://code.google.com/p/v8/source/detail?r=13187

Patch Set 1 #

Patch Set 2 : format #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -8 lines)			Patch
	M	src/debug-debugger.js	View	1	1 chunk	+6 lines, -8 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Peter Rybin

Hi Yang, I need to extend protocol to allow all value types in evaluate additional ...

8 years ago (2012-12-06 00:32:13 UTC) #1

Yang

8 years ago (2012-12-10 13:52:59 UTC) #2

On 2012/12/06 00:32:13, Peter Rybin wrote:
> Hi Yang,
> 
> I need to extend protocol to allow all value types in evaluate additional
> context. Currently it only accepts the value with handle, but there is no
reason
> for this. I'm reusing 'value description' protocol part introduced earlier.
> 
> Peter

LGTM.

Expand Messages | Collapse Messages