Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Unified Diff: src/debug-debugger.js

Issue 11448030: Allow all value types in evaluate additional context (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: format Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug-debugger.js
diff --git a/src/debug-debugger.js b/src/debug-debugger.js
index ea1a17d04b4f67fb2f88df25f64656a773869118..eef12a9116864c6fd43107a21ee826480f8a6734 100644
--- a/src/debug-debugger.js
+++ b/src/debug-debugger.js
@@ -2143,16 +2143,14 @@ DebugCommandProcessor.prototype.evaluateRequest_ = function(request, response) {
additional_context_object = {};
for (var i = 0; i < additional_context.length; i++) {
var mapping = additional_context[i];
- if (!IS_STRING(mapping.name) || !IS_NUMBER(mapping.handle)) {
+
+ if (!IS_STRING(mapping.name)) {
return response.failed("Context element #" + i +
- " must contain name:string and handle:number");
- }
- var context_value_mirror = LookupMirror(mapping.handle);
- if (!context_value_mirror) {
- return response.failed("Context object '" + mapping.name +
- "' #" + mapping.handle + "# not found");
+ " doesn't contain name:string property");
}
- additional_context_object[mapping.name] = context_value_mirror.value();
+
+ var raw_value = DebugCommandProcessor.resolveValue_(mapping);
+ additional_context_object[mapping.name] = raw_value;
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698