- Do not read past the end of the utf32_array.

runtime/vm/object.cc

Index: runtime/vm/object.cc
===================================================================
--- runtime/vm/object.cc	(revision 15726)
+++ runtime/vm/object.cc	(working copy)
@@ -9996,7 +9996,7 @@
 bool String::Equals(const int32_t* utf32_array, intptr_t len) const {
   CodePointIterator it(*this);
   intptr_t i = 0;
-  while (it.Next()) {
+  while (it.Next() && (i < len)) {

[erikcorry, 2012/12/05 10:54:06]

LGTM.

Obvious optimization:  If len > this.length() then return false, and if len <
this.length() / 2 then you can also return false.

[Ivan Posva, 2012/12/07 17:18:06]

Different CL.

     if (it.Current() != static_cast<int32_t>(utf32_array[i])) {
       return false;
     }