- Do not read past the end of the utf32_array.

runtime/vm/object.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/object.h"
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "vm/assembler.h"
 #include "vm/bigint_operations.h"
@@ skipping 9978 matching lines @@
       return false;
     }
   }
   return true;
 }
 
 
 bool String::Equals(const int32_t* utf32_array, intptr_t len) const {
   CodePointIterator it(*this);
   intptr_t i = 0;
-  while (it.Next()) {
+  while (it.Next() && (i < len)) {

[erikcorry, 2012/12/05 10:54:06]

LGTM.

Obvious optimization:  If len > this.length() then return false, and if len <
this.length() / 2 then you can also return false.

[Ivan Posva, 2012/12/07 17:18:06]

Different CL.

     if (it.Current() != static_cast<int32_t>(utf32_array[i])) {
       return false;
     }
     ++i;
   }
   if (i != len) {
     return false;
   }
   return true;
 }
@@ skipping 2109 matching lines @@
   }
   return result.raw();
 }
 
 
 const char* WeakProperty::ToCString() const {
   return "_WeakProperty";
 }
 
 }  // namespace dart