Issue 11447009: - Do not read past the end of the utf32_array.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11447009: - Do not read past the end of the utf32_array. (Closed)

Created:
8 years ago by Ivan Posva

Modified:
8 years ago

Reviewers:
siva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Do not read past the end of the utf32_array. Committed: https://code.google.com/p/dart/source/detail?r=15847

Patch Set 2 : #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -6 lines)			Patch
	M	runtime/vm/object.cc	View	1	1 chunk	+7 lines, -6 lines	0 comments	Download
	M	runtime/vm/object_test.cc	View	1	1 chunk	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

erikcorry

https://codereview.chromium.org/11447009/diff/1/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/11447009/diff/1/runtime/vm/object.cc#newcode9999 runtime/vm/object.cc:9999: while (it.Next() && (i < len)) { LGTM. Obvious ...

8 years ago (2012-12-05 10:54:06 UTC) #2

Ivan Posva

8 years ago (2012-12-07 17:18:06 UTC) #5

https://codereview.chromium.org/11447009/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/11447009/diff/1/runtime/vm/object.cc#newcode9999
runtime/vm/object.cc:9999: while (it.Next() && (i < len)) {
On 2012/12/05 10:54:06, erikcorry wrote:
> LGTM.
> 
> Obvious optimization:  If len > this.length() then return false, and if len <
> this.length() / 2 then you can also return false.

Different CL.

Expand Messages | Collapse Messages

Issue 11447009: - Do not read past the end of the utf32_array. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages