Issue 1144673002: Make it possible to Paint elements into a display list.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1144673002: Make it possible to Paint elements into a display list. (Closed)

Created:
5 years, 7 months ago by eseidel

Modified:
5 years, 7 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Make it possible to Paint elements into a display list. Currently said elements need to be in the DOM and have already been laid out for this to work, but follow-up patches will remove these restrictions. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/54e2087c60dd96d32c1e9930bfda15afda974c76

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -0 lines)			Patch
M	sky/engine/core/dom/Element.h	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	sky/engine/core/dom/Element.cpp	View		2 chunks	+15 lines, -0 lines	0 comments	Download
M	sky/engine/core/dom/Element.idl	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	sky/engine/core/painting/Canvas.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A	sky/examples/raw/paint_element_into_displaylist.sky	View	1	1 chunk	+24 lines, -0 lines	0 comments	Download

Total messages: 5 (1 generated)

abarth-chromium

LGTM We talked about a next step of recording the element once and playing it ...

5 years, 7 months ago (2015-05-18 20:09:44 UTC) #4

eseidel

5 years, 7 months ago (2015-05-18 21:50:04 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
54e2087c60dd96d32c1e9930bfda15afda974c76 (presubmit successful).