Ignore autocomplete=off when password manager is saving the generated passwords during account crea…

chrome/browser/password_manager/password_manager.cc

Index: chrome/browser/password_manager/password_manager.cc
diff --git a/chrome/browser/password_manager/password_manager.cc b/chrome/browser/password_manager/password_manager.cc
index a00c991d1ccba8542a4bff4bd0f61435a23cfbbb..b812ac3ad9350a143ed59037fec0af24b38f34e2 100644
--- a/chrome/browser/password_manager/password_manager.cc
+++ b/chrome/browser/password_manager/password_manager.cc
@@ -181,6 +181,11 @@ void PasswordManager::ProvisionallySavePassword(const PasswordForm& form) {
   if (!manager->HasValidPasswordForm())
     return;
 
+  // Don't save the password if it is not a generated password and autocomplete
+  // is turned off.

[Ilya Sherman, 2012/12/06 22:55:59]

Optional nit: I would suggest phrasing this as follows:

"Always save generated passwords, as the user expresses explicit intent for
Chrome to manage such passwords.  For other passwords, respect the autocomplete
attribute."

[zysxqn, 2012/12/06 23:54:49]

Done.

+  if (!manager->HasGeneratedPassword() && !form.password_should_autocomplete)
+    return;
+
   PasswordForm provisionally_saved_form(form);
   provisionally_saved_form.ssl_valid = form.origin.SchemeIsSecure() &&
       !delegate_->DidLastPageLoadEncounterSSLErrors();