Ignore autocomplete=off when password manager is saving the generated passwords during account crea…

chrome/browser/password_manager/password_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/password_manager/password_manager.h"
 
 #include "base/metrics/histogram.h"
 #include "base/threading/platform_thread.h"
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
@@ skipping 163 matching lines @@
 
   // Also get out of here if the user told us to 'never remember' passwords for
   // this form.
   if (manager->IsBlacklisted())
     return;
 
   // Bail if we're missing any of the necessary form components.
   if (!manager->HasValidPasswordForm())
     return;
 
+  // Don't save the password if it is not a generated password and autocomplete
+  // is turned off.

[Ilya Sherman, 2012/12/06 22:55:59]

Optional nit: I would suggest phrasing this as follows:

"Always save generated passwords, as the user expresses explicit intent for
Chrome to manage such passwords.  For other passwords, respect the autocomplete
attribute."

[zysxqn, 2012/12/06 23:54:49]

Done.

+  if (!manager->HasGeneratedPassword() && !form.password_should_autocomplete)
+    return;
+
   PasswordForm provisionally_saved_form(form);
   provisionally_saved_form.ssl_valid = form.origin.SchemeIsSecure() &&
       !delegate_->DidLastPageLoadEncounterSSLErrors();
   provisionally_saved_form.preferred = true;
   manager->ProvisionallySave(provisionally_saved_form);
   provisional_save_manager_.swap(manager);
 }
 
 void PasswordManager::SetObserver(LoginModelObserver* observer) {
   observer_ = observer;
@@ skipping 113 matching lines @@
       delegate_->FillPasswordForm(fill_data);
       return;
     }
     default:
       if (observer_) {
         observer_->OnAutofillDataAvailable(preferred_match.username_value,
                                            preferred_match.password_value);
       }
   }
 }